Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node inspect restart prints Debugging/For-help message twice #39272

Closed
Trott opened this issue Jul 5, 2021 · 0 comments · Fixed by #39334
Closed

node inspect restart prints Debugging/For-help message twice #39272

Trott opened this issue Jul 5, 2021 · 0 comments · Fixed by #39334
Labels
debugger Issues and PRs related to the debugger subsystem.

Comments

@Trott
Copy link
Member

Trott commented Jul 5, 2021

  • Version: 16.x.x
  • Platform: macOS
  • Subsystem: debugger

What steps will reproduce the bug?

$ node inspect test/fixtures/debugger/three-lines.js 
< Debugger listening on ws://127.0.0.1:9229/b7e232ed-227e-4482-864d-e58a37e4bc94
< 
< For help, see: https://nodejs.org/en/docs/inspector
< 
< Debugger attached.
< 
 ok
Break on start in test/fixtures/debugger/three-lines.js:1
> 1 let x = 1;
  2 x = x + 1;
  3 module.exports = x;
debug> restart
< Debugger listening on ws://127.0.0.1:9229/b7e232ed-227e-4482-864d-e58a37e4bc94
< For help, see: https://nodejs.org/en/docs/inspector
< 
< Debugger listening on ws://127.0.0.1:9229/d0c753b1-e93a-48e5-8323-df845d308bcd
< For help, see: https://nodejs.org/en/docs/inspector
< 
connecting to 127.0.0.1:9229 ... ok
< Debugger attached.
< 
Break on start in test/fixtures/debugger/three-lines.js:1
> 1 let x = 1;
  2 x = x + 1;
  3 module.exports = x;
debug> 

How often does it reproduce? Is there a required condition?

Every time.

What is the expected behavior?

After issuing restart in the debugger CLI, it will only print "Debugger listening on...For help..." message once.

What do you see instead?

It repeats the initial message from the start of the session, then issues the correct second message.

Additional information

Trott added a commit to Trott/io.js that referenced this issue Jul 5, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 5, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 6, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 6, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
@Ayase-252 Ayase-252 added the debugger Issues and PRs related to the debugger subsystem. label Jul 7, 2021
Trott added a commit to Trott/io.js that referenced this issue Jul 7, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 7, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 8, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272

PR-URL: nodejs#39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Jul 10, 2021
targos pushed a commit that referenced this issue Jul 11, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Jul 11, 2021
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 12, 2021
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: nodejs#39272
Trott added a commit to Trott/io.js that referenced this issue Jul 12, 2021
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: nodejs#39272
@Trott Trott closed this as completed in a518e4b Jul 12, 2021
targos pushed a commit that referenced this issue Jul 13, 2021
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: #39272

PR-URL: #39334
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
targos pushed a commit that referenced this issue Sep 4, 2021
Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue Sep 4, 2021
Currently, we say "listening" when we are ending the server. Change it
to "ending".

Fixes: #39272

PR-URL: #39334
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yash Ladha <yash@yashladha.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger Issues and PRs related to the debugger subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants