Closed
Conversation
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing.
Member
Author
|
@nodejs/linting |
watilde
approved these changes
Aug 21, 2021
targos
approved these changes
Aug 21, 2021
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Member
|
targos
reviewed
Aug 21, 2021
Contributor
I suppose we need to either make Rollup output ESM ( |
Member
Author
I made it ESM. PTAL |
Member
Author
|
(By the way, my reason for the fast-track request is that right now, the linter isn't doing anything, so errors may be landing in doc changes. Right now, there are no lint errors. I'd like to get this landed ASAP to minimize the possibility of errors appearing between now and when this lands.) |
targos
requested changes
Aug 21, 2021
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
tools/lint-md.js is referenced in:
.eslintignorevcbuild.bat
Member
Author
Whoops, forgot to grep. OK, fixed. |
targos
approved these changes
Aug 21, 2021
aduh95
approved these changes
Aug 21, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/39832 ✔ Done loading data for nodejs/node/pull/39832 ----------------------------------- PR info ------------------------------------ Title tools: fix markdown linting (#39832) Author Rich Trott (@Trott) Branch Trott:lint-preset-update -> nodejs:master Labels tools, fast-track Commits 4 - tools: fix markdown linting - fixup! tools: fix markdown linting - fixup! fixup! tools: fix markdown linting - fixup! fixup! fixup! tools: fix markdown linting Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 21 Aug 2021 14:13:10 GMT ✔ Approvals: 3 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/39832#pullrequestreview-735498792 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39832#pullrequestreview-735505690 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/39832#pullrequestreview-735505770 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1154347243 |
github-actions
bot
added
the
commit-queue-failed
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
added
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 1deafcd...1110947 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 22, 2021
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: #39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates remark-preset-lint-node to 3.0.1, which actually works
unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually
linting!)
It also updates rollup and the rollup config. So this uses the
latest everything as of this writing.