Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jul 9, 2021

Fixtures are not linted so eslint-disable comments are unnecessary.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 9, 2021
@Trott Trott force-pushed the no-lint-fixtures branch from a052efb to 38d29a4 Compare July 9, 2021 04:52
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 10, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: nodejs#39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott Trott force-pushed the no-lint-fixtures branch from 38d29a4 to 8970fa9 Compare July 11, 2021 04:53
@Trott
Copy link
Member Author

Trott commented Jul 11, 2021

Landed in 8970fa9

@Trott Trott merged commit 8970fa9 into nodejs:master Jul 11, 2021
@Trott Trott deleted the no-lint-fixtures branch July 11, 2021 04:53
targos pushed a commit that referenced this pull request Jul 11, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: #39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Fixtures are not linted so eslint-disable comments are unnecessary.

PR-URL: #39320
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants