v14.18.0 release proposal

.eslintignore

@@ -4,7 +4,7 @@ test/addons/??_*
 test/fixtures
 test/message/esm_display_syntax_error.mjs
 tools/icu
-tools/lint-md.js
+tools/lint-md.mjs
 tools/node-lint-md-cli-rollup/dist
 benchmark/tmp
 doc/**/*.js

.eslintrc.js

@@ -18,6 +18,7 @@ const hacks = [
   'eslint-plugin-markdown',
   '@babel/eslint-parser',
   '@babel/plugin-syntax-class-properties',
+  '@babel/plugin-syntax-import-assertions',
   '@babel/plugin-syntax-top-level-await',
 ];
 Module._findPath = (request, paths, isMain) => {
@@ -41,6 +42,7 @@ module.exports = {
     babelOptions: {
       plugins: [
         Module._findPath('@babel/plugin-syntax-class-properties'),
+        Module._findPath('@babel/plugin-syntax-import-assertions'),
         Module._findPath('@babel/plugin-syntax-top-level-await'),
       ],
     },
@@ -124,7 +126,13 @@ module.exports = {
         ignorePattern: '.*',
       },
     }],
-    'comma-dangle': ['error', 'only-multiline'],
+    'comma-dangle': ['error', {
+      arrays: 'always-multiline',
+      exports: 'only-multiline',
+      functions: 'only-multiline',
+      imports: 'only-multiline',
+      objects: 'only-multiline',
+    }],
     'comma-spacing': 'error',
     'comma-style': 'error',
     'computed-property-spacing': 'error',
@@ -155,6 +163,7 @@ module.exports = {
       code: 80,
       ignorePattern: '^// Flags:',
       ignoreRegExpLiterals: true,
+      ignoreTemplateLiterals: true,
       ignoreUrls: true,
       tabWidth: 2,
     }],

.github/CODEOWNERS

@@ -22,7 +22,6 @@
 /doc/guides/contributing/pull-requests.md @nodejs/tsc
 /doc/guides/collaborator-guide.md @nodejs/tsc
 /doc/guides/offboarding.md @nodejs/tsc
-/doc/guides/onboarding-extras.md @nodejs/tsc
 
 # streams
 
@@ -97,6 +96,12 @@
 /doc/guides/adding-new-napi-api.md @nodejs/n-api
 /doc/api/n-api.md @nodejs/n-api
 
+# gyp
+
+*.gyp @nodejs/gyp
+*.gypi @nodejs/gyp
+/tools/gyp/**/* @nodejs/gyp
+
 # WASI
 /deps/uvwasi/ @nodejs/wasi
 /doc/api/wasi.md @nodejs/wasi
@@ -118,3 +123,8 @@
 # V8
 /deps/v8/* @nodejs/v8-update
 /tools/v8_gypfiles/* @nodejs/v8-update
+
+# Actions
+
+/.github/workflows/* @nodejs/actions
+/tools/actions/* @nodejs/actions

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -0,0 +1,45 @@
+name: "\U0001F41B Bug report"
+description: Create a report to help us improve
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for reporting an issue.
+
+        This issue tracker is for bugs and issues found within Node.js core.
+        If you require more general support please file an issue on our help repo. https://github.com/nodejs/help
+
+        Please fill in as much of the form below as you're able.
+  - type: input
+    attributes:
+      label: Version
+      description: Output of `node -v`
+  - type: input
+    attributes:
+      label: Platform
+      description: |
+        UNIX: output of `uname -a`
+        Windows: output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console
+  - type: input
+    attributes:
+      label: Subsystem
+      description: If known, please specify affected core module name
+  - type: textarea
+    attributes:
+      label: What steps will reproduce the bug?
+      description: Enter details about your bug, preferably a simple code snippet that can be run using `node` directly without installing third-party dependencies.
+  - type: textarea
+    attributes:
+      label: How often does it reproduce? Is there a required condition?
+  - type: textarea
+    attributes:
+      label: What is the expected behavior?
+      description: If possible please provide textual output instead of screenshots.
+  - type: textarea
+    attributes:
+      label: What do you see instead?
+      description: If possible please provide textual output instead of screenshots.
+  - type: textarea
+    attributes:
+      label: Additional information
+      description: Tell us anything else you think we should know.

.github/workflows/authors.yml

@@ -0,0 +1,22 @@
+name: "authors update"
+on:
+  workflow_dispatch:
+
+jobs:
+  authors_update:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: '0' # this is required to actually get all the authors
+      - run: "tools/update-authors.js" # run the AUTHORS tool
+      - uses: gr2m/create-or-update-pull-request-action@v1 # create a PR or update the Action's existing PR
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          title: "meta: update AUTHORS"
+          body: "If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the `authors.yml` GitHub Action, which runs `tools/update-authors.js` and submits a new PR or updates an existing PR.\n\nPlease note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR."
+          branch: "actions/authors-update" # custom branch *just* for this Action.
+          commit-message: "meta: update AUTHORS"
+          author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
+          labels: meta

.github/workflows/auto-start-ci.yml

@@ -10,7 +10,7 @@ on:
     - cron: "*/5 * * * *"
 
 env:
-  NODE_VERSION: 14.x
+  NODE_VERSION: lts/*
 
 jobs:
   startCI:

.github/workflows/build-tarball.yml

@@ -2,6 +2,7 @@ name: Build from tarball
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
       - master
@@ -57,8 +58,8 @@ jobs:
           name: tarballs
       - name: Extract tarball
         run: |
-          tar xzf tarballs/*.tar.gz
-          echo "TAR_DIR=`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
+          tar xzf tarballs/*.tar.gz -C $RUNNER_TEMP
+          echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
       - name: Copy directories needed for testing
         run: |
           cp -r tools/node_modules $TAR_DIR/tools

.github/workflows/build-windows.yml

@@ -2,6 +2,7 @@ name: build-windows
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
       - master

.github/workflows/commit-lint-problem-matcher.json

@@ -0,0 +1,13 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "core-validate-commit",
+      "pattern": [
+        {
+          "regexp": "^not ok \\d+ (.*)$",
+          "message": 1
+        }
+      ]
+    }
+  ]
+}

.github/workflows/commit-lint.yml

@@ -0,0 +1,23 @@
+name: "Commit messages adheres to guidelines at https://goo.gl/p2fr5Q"
+
+on: [pull_request]
+
+env:
+  NODE_VERSION: lts/*
+
+jobs:
+  lint-commit-message:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          # Last 100 commits should be enough for a PR
+          fetch-depth: 100
+      - name: Install Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+      - name: Validate commit messages
+        run: |
+          echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
+          git log --oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | grep -v -e fixup -e squash | awk '{ print $1 }' |  xargs npx -q core-validate-commit --no-validate-metadata --tap

.github/workflows/commit-queue.yml

@@ -15,7 +15,7 @@ on:
     - cron: "*/5 * * * *"
 
 env:
-  NODE_VERSION: 14.x
+  NODE_VERSION: lts/*
 
 jobs:
   commitQueue:

.github/workflows/daily.yml

@@ -6,7 +6,7 @@ on:
     - cron: "0 0 * * *"
 
 env:
-  NODE_VERSION: 14.x
+  NODE_VERSION: lts/*
 
 jobs:
   build-lto:

.github/workflows/find-inactive-collaborators.yml

@@ -0,0 +1,41 @@
+name: Find inactive collaborators
+
+on:
+  schedule:
+    # Run on the 15th day of the month at 4:05 AM UTC.
+    - cron: '5 4 15 * *'
+
+  workflow_dispatch:
+
+env:
+  NODE_VERSION: 16.x
+  NUM_COMMITS: 5000
+
+jobs:
+  find:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: ${{ env.NUM_COMMITS }}
+
+      - name: Use Node.js ${{ env.NODE_VERSION }}
+        uses: actions/setup-node@v2
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+
+      - name: Find inactive collaborators
+        run: tools/find-inactive-collaborators.mjs ${{ env.NUM_COMMITS }}
+
+      - name: Open pull request
+        uses: gr2m/create-or-update-pull-request-action@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          author: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
+          body: This PR was generated by tools/find-inactive-collaborators.yml.
+          commit-message: "meta: move one or more collaborators to emeritus"
+          labels: meta
+          title: "meta: move one or more collaborators to emeritus"

.github/workflows/label-pr.yml

@@ -11,4 +11,5 @@ jobs:
     steps:
       - uses: nodejs/node-pr-labeler@v1
         with:
+          repo-token: ${{ secrets.GH_USER_TOKEN }}
           configuration-path: .github/label-pr-config.yml

.github/workflows/linters.yml

@@ -2,6 +2,7 @@ name: linters
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
       - master
@@ -11,7 +12,7 @@ on:
 
 env:
   PYTHON_VERSION: 3.9
-  NODE_VERSION: 14.x
+  NODE_VERSION: lts/*
 
 jobs:
   lint-addon-docs:

.github/workflows/misc.yml

@@ -2,6 +2,7 @@ name: misc
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
       - master
@@ -10,7 +11,7 @@ on:
       - v[0-9]+.x
 
 env:
-  NODE_VERSION: 14.x
+  NODE_VERSION: lts/*
 
 jobs:
   build-docs:

.github/workflows/test-asan.yml

@@ -9,9 +9,12 @@ on:
       - v[0-9]+.x-staging
       - v[0-9]+.x
     paths-ignore:
+      - '**.md'
       - 'doc/**'
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
     paths-ignore:
+      - '**.md'
       - 'doc/**'
 
 env:

.github/workflows/test-linux.yml

@@ -2,6 +2,7 @@ name: test-linux
 
 on:
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   push:
     branches:
       - master