Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update markdown lint dependencies #39770

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 15, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 15, 2021
@Trott
Copy link
Member Author

Trott commented Aug 15, 2021

rollup and remark/unified-args stop playing nicely with each other if they are brought entirely up to date, but this brings them as far as they can go without problems. (Maybe a bugfix release in one of the packages will fix everything and we can update fully. Or we can go with #39760 and remove rollup.)

This also removes an unnecessary dependency (remark-lint). We're using a preset, and presets already include remark-lint itself. We'd only need remark-lint if we were using only plugins and no preset.

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2021
@github-actions
Copy link
Contributor

Landed in fe4d562...f7a2aec

@github-actions github-actions bot closed this Aug 17, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 17, 2021
PR-URL: #39770
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Aug 22, 2021
PR-URL: #39770
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
PR-URL: #39770
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott Trott deleted the deps-updated branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants