[Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. SRP Core Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
kecho
force-pushed
the
graphics/IESImporterNegativeValsFix
branch
from
a51ba47 to
505d8b9
Compare
TomasKiniulis
approved these changes
Jan 4, 2022
* Added code for clamping * CHANGELOG * Increasing the importer version so we reimport ies profile textures
kecho
force-pushed
the
graphics/IESImporterNegativeValsFix
branch
from
505d8b9 to
7ba5c07
Compare
sebastienlagarde
approved these changes
Jan 11, 2022
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
sebastienlagarde
added
needs-backport-2022.1
backported-2022.1
and removed
needs-backport-2021.2
needs-backport-2022.1
labels
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Jan 13, 2022
* Fix FBX Material * [HDRP] Fix rendering when adding an incompatible platform to the project #6495 * Updated Physically Based Sky documentation with more warnings about warmup cost. #6498 * Fixed shaders craeted with the custom pass renderers template not being compatible with SRP batcher (case 1383694) (#6501) * Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511 * Avoid typed load on volumetric fog filtering on platforms that don't support it #6513 * Fixed the property name of screen weight distance (#6586) * Documentation and images for custom mip for texture samplers (#6592) * Documentation and images for custom mip for texture samplers * Code review suggested changes. * Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600 * Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601 * Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613 * Urp/fix 1378692 #6627 * Fixed a crash with render graph viewer #6629 * [HDRP] Fix tile/cluster debug for Decal and Fog #6635 * Minor rewording of PT doc. (#6637) * Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643 * Fix (#6649) * [HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659 * Review new warmup cost section (#6683) A few fixes applied to the changes in #6498 and #6323. * Path fixes (#6692) Updated incorrect menu paths. * fixed typo "pratices" -> "practices" in ToC (#6699) * fixed link to decal.md (#6700) * Volume docs bugfixes (#6714) * Volume docs bugfixes Updates screenshots, menu paths and fixed some typos and inaccuracies. * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * NeedMotionVectorForTransparent was checking for wrong flag #6719 * [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722 * [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669 Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: esdasuka <soner.sen@gmail.com> Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Jan 13, 2022
* Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511 * Update .gitignore * Avoid typed load on volumetric fog filtering on platforms that don't support it #6513 * Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600 * Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601 * Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613 * Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643 * Fix fbx material #6491 * Urp/fix 1378692 #6627 * [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669 * Update 1225_Lit_SpeedTree8SG.png * update ref screenshots * Update 004-CloudsFlaresDecals.png Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: esdasuka <soner.sen@gmail.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
IES profiles that have splines going slightly below 0 or above 1 will cause some byte overflow artifacts.
This change clamps the evaluated spline to be within 0 and 1 range
https://fogbugz.unity3d.com/f/cases/1380357/
Before:
After:
Testing status
Tested with the fogbugz example.