Physically Based Sky documentation now mentions the warmup cost explicitly #6323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Nov 25, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Nov 28, 2021
…citly (#6323) * Physically Based Sky documentation now mentions the warmup cost explicitly. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Nov 29, 2021
* [Core] Fix XR support in CoreUtils.Drawfullscreen (#6287) * Fix XR support in CoreUtils.DrawFullscreen function * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Physically Based Sky documentation now mentions the warmup cost explicitly (#6323) * Physically Based Sky documentation now mentions the warmup cost explicitly. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Merge HD/bugfix #6387 * Update CHANGELOG.md * fix compilation issue * Fix compil issue bis * Update PostProcessSystem.cs * Fix compil issue - bis bis * Update PostProcessSystem.RenderGraph.cs * Revert: [HDRP] Fix rasterized accumulation motion blur when DoF is enabled #6380 * Revert Fixed broken rendering when duplicating a camera while the Rendering Debugger is opened. #6289 Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Dec 8, 2021
…citly (#6323) * Physically Based Sky documentation now mentions the warmup cost explicitly. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Dec 9, 2021
* - Fixed edges and ghosting appearing on shadow matte due to the shadow being black outside the range of the light (case 1371441). #6279 * Fixed interpolation issue with wind orientation (case 1379841). #6284 * Fixed range fields for depth of field #6285 * [Core] Fix XR support in CoreUtils.Drawfullscreen #6287 * ** Fixing DLSS failing when MV are disabled ** (#6292) * Using texture types instead of RenderTexture types for DLSSPass * Changelog * Formatting Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [Fix] Lens Flare visible when being behind a camera with Panini Projection on (case 1370214) (#6293) * Fix panini for LensFlare * Add changelog * Update CHANGELOG.md * Fixed the ray tracing acceleration structure build marker not being included in the ray tracing stats (case 1379383). #6277 * [HDRP] Remove alpha from local volumetric fog color field #6310 * [HDRP] Changed default numbder of physically based sky bounce from 8 to 3 #6304 * [HDRP] Improve decal performances when they use different material and the same draw order. #6303 * [HDRP] Update reference screenshots #6404 * Fixed Nans happening due to volumetric clouds when the pixel color is perfectly black (case 1379185). #6311 * Fixed missing information in the tooltip of affects smooth surfaces of the ray traced reflections denoiser (case 1376918). #6321 * Physically Based Sky documentation now mentions the warmup cost explicitly (#6323) * Physically Based Sky documentation now mentions the warmup cost explicitly. * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Reviewed PR #6031 (#6340) * Reviewed PR #6031 Also generally improved this doc, fixed typos and added screenshots. * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * Fix preview scene objects marked dirty by migration #6361 * [HDRP][Path Tracing] Fixed PS5 build compilation warnings #6362 * Fix compil issue * Apply formatting changes * Update VisualEnvironment.cs * Fix HDRP warning (#6396) * [HDRP][Metal] * Update reference screenshots sky Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Jan 13, 2022
* Fixed the property name of screen weight distance (#6586) * Documentation and images for custom mip for texture samplers (#6592) * Documentation and images for custom mip for texture samplers * Code review suggested changes. * [HDRP] Fix tile/cluster debug for Decal and Fog #6635 * Minor rewording of PT doc. (#6637) * Review new warmup cost section (#6683) A few fixes applied to the changes in #6498 and #6323. * Path fixes (#6692) Updated incorrect menu paths. * fixed typo "pratices" -> "practices" in ToC (#6699) * fixed link to decal.md (#6700) * Volume docs bugfixes (#6714) * Volume docs bugfixes Updates screenshots, menu paths and fixed some typos and inaccuracies. * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * NeedMotionVectorForTransparent was checking for wrong flag #6719 * [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722 * Fix (#6649) * [HDRP] Fix rendering when adding an incompatible platform to the project #6495 * Fixed a crash with render graph viewer * Fixed Custom Pass DrawRenderers shader not compatible with SRP Batcher #6501 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Jan 13, 2022
* Fix FBX Material * [HDRP] Fix rendering when adding an incompatible platform to the project #6495 * Updated Physically Based Sky documentation with more warnings about warmup cost. #6498 * Fixed shaders craeted with the custom pass renderers template not being compatible with SRP batcher (case 1383694) (#6501) * Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511 * Avoid typed load on volumetric fog filtering on platforms that don't support it #6513 * Fixed the property name of screen weight distance (#6586) * Documentation and images for custom mip for texture samplers (#6592) * Documentation and images for custom mip for texture samplers * Code review suggested changes. * Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600 * Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601 * Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613 * Urp/fix 1378692 #6627 * Fixed a crash with render graph viewer #6629 * [HDRP] Fix tile/cluster debug for Decal and Fog #6635 * Minor rewording of PT doc. (#6637) * Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643 * Fix (#6649) * [HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659 * Review new warmup cost section (#6683) A few fixes applied to the changes in #6498 and #6323. * Path fixes (#6692) Updated incorrect menu paths. * fixed typo "pratices" -> "practices" in ToC (#6699) * fixed link to decal.md (#6700) * Volume docs bugfixes (#6714) * Volume docs bugfixes Updates screenshots, menu paths and fixed some typos and inaccuracies. * Apply formatting changes Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> * NeedMotionVectorForTransparent was checking for wrong flag #6719 * [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722 * [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669 Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: esdasuka <soner.sen@gmail.com> Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Physically Based Sky documentation now mentions the warmup cost explicitly
JIRA: https://jira.unity3d.com/browse/DOCF-873