Skip to content

[HDRP] Backport various PRs #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 13, 2022
Merged

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jan 13, 2022

Purpose of this PR

Fix FBX Material
[HDRP] Fix rendering when adding an incompatible platform to the proj…
Updated Physically Based Sky documentation with more warnings about w…
Fixed shaders craeted with the custom pass renderers template not bei…
Fixed the fade in mode of the clouds not impacting the volumetric clo…
Avoid typed load on volumetric fog filtering on platforms that don't …
Fixed the property name of screen weight distance (#6586)
Documentation and images for custom mip for texture samplers (#6592)
Fixed potential asymmetrical resource release in the volumetric cloud…
Fixed the intensity of the sky being reduced signficantly even if the…
Fixed the rt screen space shadows not using the correct asset for all…
Urp/fix 1378692 #6627
Fixed a crash with render graph viewer #6629
[HDRP] Fix tile/cluster debug for Decal and Fog #6635
Minor rewording of PT doc. (#6637)
Changed the behavior the max ray length for recursive rendering to m…
Fix (#6649)
[HDRP] Fix issue with dynamic RendererList culling option getting ign…
Review new warmup cost section (#6683)
Path fixes (#6692)
fixed typo "pratices" -> "practices" in ToC (#6699)
fixed link to decal.md (#6700)
Volume docs bugfixes (#6714)
NeedMotionVectorForTransparent was checking for wrong flag #6719
[HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722
[Fogbugz # 380357] Fixing negative overflowing of IES attenuation spl…


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

sebastienlagarde and others added 25 commits January 13, 2022 15:59
* Documentation and images for custom mip for texture samplers

* Code review suggested changes.
A few fixes applied to the changes in #6498 and #6323.
Updated incorrect menu paths.
* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde changed the title Hdrp/backport misc 22 1 [HDRP] Backport various PRs Jan 13, 2022
@sebastienlagarde sebastienlagarde marked this pull request as ready for review January 13, 2022 15:30
@sebastienlagarde sebastienlagarde merged commit f89d0ff into 2022.1/staging Jan 13, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/backport-misc-22-1 branch January 13, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.