Skip to content

Documentation and images for custom mip for texture samplers #6592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

kecho
Copy link
Contributor

@kecho kecho commented Dec 13, 2021

Purpose of this PR

Adding an example and images of how to author a custom mip for a texture (requested by NVIDIA).

Docs team jira: https://jira.unity3d.com/browse/DOCF-983


Testing status

No code changes, just doc files.

@github-actions github-actions bot added the HDRP label Dec 13, 2021
@kecho kecho requested a review from Vic-Cooper December 13, 2021 16:20
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@kecho kecho force-pushed the HDRP/CustomMipDocumentationForDLSS branch from 4fd0028 to b6fb5bc Compare December 13, 2021 16:26
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes for clarity. (Also the HDRP Asset docs link was incorrect).

To enable automatic mip bias correction when DLSS is enabled, enable the checkbox **Use Mip Bias** in the [HDRP Asset](HDRO-Asset.md).

If a specific custom mip bias is desired for a texture, the following custom function node can be created with the following body:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To enable automatic mip bias correction when you enable DLSS, open the HDRP Asset and enable the Use Mip Bias checkbox .

If you need a specific custom mip bias for a Texture, create a custom sampler that samples from TextureInput, SamplerInput, UV, and MipBias. To do this, enter the following script into the Node Settings ' Body field. The images below display this example:

Copy link
Contributor Author

@kecho kecho Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks @Vic-Cooper !

@kecho kecho requested a review from Vic-Cooper December 14, 2021 20:01
@sebastienlagarde sebastienlagarde merged commit 107a519 into master Dec 15, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/CustomMipDocumentationForDLSS branch December 15, 2021 14:44
sebastienlagarde pushed a commit that referenced this pull request Jan 13, 2022
* Documentation and images for custom mip for texture samplers

* Code review suggested changes.
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
* Fixed the property name of screen weight distance (#6586)

* Documentation and images for custom mip for texture samplers (#6592)

* Documentation and images for custom mip for texture samplers

* Code review suggested changes.

* [HDRP] Fix tile/cluster debug for Decal and Fog #6635

* Minor rewording of PT doc. (#6637)

* Review new warmup cost section (#6683)

A few fixes applied to the changes in #6498 and #6323.

* Path fixes (#6692)

Updated incorrect menu paths.

* fixed typo "pratices" -> "practices" in ToC (#6699)

* fixed link to decal.md (#6700)

* Volume docs bugfixes (#6714)

* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* NeedMotionVectorForTransparent was checking for wrong flag #6719

* [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722

* Fix (#6649)

* [HDRP] Fix rendering when adding an incompatible platform to the project #6495

* Fixed a crash with render graph viewer

* Fixed Custom Pass DrawRenderers shader not compatible with SRP Batcher #6501

Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
sebastienlagarde pushed a commit that referenced this pull request Jan 13, 2022
* Documentation and images for custom mip for texture samplers

* Code review suggested changes.
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
* Fix FBX Material

* [HDRP] Fix rendering when adding an incompatible platform to the project #6495

* Updated Physically Based Sky documentation with more warnings about warmup cost. #6498

* Fixed shaders craeted with the custom pass renderers template not being compatible with SRP batcher (case 1383694) (#6501)

* Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

* Avoid typed load on volumetric fog filtering on platforms that don't support it #6513

* Fixed the property name of screen weight distance (#6586)

* Documentation and images for custom mip for texture samplers (#6592)

* Documentation and images for custom mip for texture samplers

* Code review suggested changes.

* Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600

* Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601

* Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613

* Urp/fix 1378692 #6627

* Fixed a crash with render graph viewer #6629

* [HDRP] Fix tile/cluster debug for Decal and Fog #6635

* Minor rewording of PT doc. (#6637)

* Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643

* Fix (#6649)

* [HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659

* Review new warmup cost section (#6683)

A few fixes applied to the changes in #6498 and #6323.

* Path fixes (#6692)

Updated incorrect menu paths.

* fixed typo "pratices" -> "practices" in ToC (#6699)

* fixed link to decal.md (#6700)

* Volume docs bugfixes (#6714)

* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* NeedMotionVectorForTransparent was checking for wrong flag #6719

* [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722

* [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669

Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: esdasuka <soner.sen@gmail.com>
Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants