Skip to content

Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 15, 2021
Merged

Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

merged 4 commits into from
Dec 15, 2021

Conversation

anisunity
Copy link
Contributor

https://fogbugz.unity3d.com/f/cases/1381652/
The Fade In mode and parameters were not affecting the volumetric clouds shadows which could lead to visual inconsistencies.
This PR fixes the issues and now it visually matches.

cloudsFix.mp4

Testing Status:
Tried with the different parameters combinations and seems to work fine now.

@anisunity anisunity self-assigned this Dec 7, 2021
@anisunity anisunity marked this pull request as ready for review December 7, 2021 12:58
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde requested a review from a team December 9, 2021 12:58
@anisunity
Copy link
Contributor Author

This changes the results of the standalone clouds tests, will need to update the 5 screenshots

RemyUnity
RemyUnity requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the issue mentioned in the FB case (testing on Metal).

@anisunity
Copy link
Contributor Author

@RemyUnity you'll need to show me

RemyUnity
RemyUnity approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misinterpreted the issue and what was shows in the repro, fix confirmed.

@anisunity
Copy link
Contributor Author

Updated the screenshots and relaunched the tests

@anisunity anisunity merged commit 87fb357 into master Dec 15, 2021
@anisunity anisunity deleted the HDRP/fix-1381652 branch December 15, 2021 16:14
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
@sebastienlagarde
Fixed the fade in mode of the clouds not impacting the volumetric clo…
f87df39 
…uds shadows (case 1381652). #6511
sebastienlagarde pushed a commit that referenced this pull request Jan 13, 2022
@anisunity @sebastienlagarde
Fixed the fade in mode of the clouds not impacting the volumetric clo…
a43d0ac 
…uds shadows (case 1381652). #6511
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
@sebastienlagarde @alelievr
@JulienIgnace-Unity @anisunity @FrancescoC-unity @emilybrown1 @kecho @esdasuka @simonb-unity @eturquin @pmavridis @Vic-Cooper @JMargevics
[HDRP] Backport various PRs (#6742)
f89d0ff 
* Fix FBX Material

* [HDRP] Fix rendering when adding an incompatible platform to the project #6495

* Updated Physically Based Sky documentation with more warnings about warmup cost. #6498

* Fixed shaders craeted with the custom pass renderers template not being compatible with SRP batcher (case 1383694) (#6501)

* Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

* Avoid typed load on volumetric fog filtering on platforms that don't support it #6513

* Fixed the property name of screen weight distance (#6586)

* Documentation and images for custom mip for texture samplers (#6592)

* Documentation and images for custom mip for texture samplers

* Code review suggested changes.

* Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600

* Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601

* Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613

* Urp/fix 1378692 #6627

* Fixed a crash with render graph viewer #6629

* [HDRP] Fix tile/cluster debug for Decal and Fog #6635

* Minor rewording of PT doc. (#6637)

* Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643

* Fix (#6649)

* [HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659

* Review new warmup cost section (#6683)

A few fixes applied to the changes in #6498 and #6323.

* Path fixes (#6692)

Updated incorrect menu paths.

* fixed typo "pratices" -> "practices" in ToC (#6699)

* fixed link to decal.md (#6700)

* Volume docs bugfixes (#6714)

* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* NeedMotionVectorForTransparent was checking for wrong flag #6719

* [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722

* [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669

Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: esdasuka <soner.sen@gmail.com>
Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
@sebastienlagarde @FrancescoC-unity
@anisunity @adrien-de-tocqueville @esdasuka @kecho
[HDRP] Backport various Prs (#6741)
4799632 
* Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

* Update .gitignore

* Avoid typed load on volumetric fog filtering on platforms that don't support it #6513

* Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600

* Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601

* Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613

* Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643

* Fix fbx material #6491

* Urp/fix 1378692 #6627

* [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669

* Update 1225_Lit_SpeedTree8SG.png

* update ref screenshots

* Update 004-CloudsFlaresDecals.png

Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: esdasuka <soner.sen@gmail.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@RemyUnity RemyUnity RemyUnity approved these changes

Assignees

@anisunity anisunity

Labels
backported-2021.2 backported-2022.1 HDRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anisunity @sebastienlagarde @RemyUnity