Skip to content

[HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2022
Merged

[HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659

merged 2 commits into from
Jan 13, 2022

Conversation

pmavridis
Copy link
Contributor

@pmavridis pmavridis commented Dec 21, 2021 •
edited
Loading

Purpose of this PR

https://fogbugz.unity3d.com/f/cases/1388854
The RendererList culling option was not being initialized properly in rendergraph.

The fix is trivial, but it shows that we are missing a test for this on the HDRP side.
Not sure how to test such feature, maybe it's time to enable it by default and have the perf metrics capture the regression?

Testing status

Open The HDRP template, Open the RenderGraph Viewer and in the filters select to show culled passes:
Now toggle the "Dynamic render pass culling" option in the HDRP global settings.

  • Before: the number of culled passes stays the same, regardless of dynamic culling.
  • After: the number of culled passes is now higher and changes with the view.

@pmavridis pmavridis requested review from alelievr, JulienIgnace-Unity and a team December 21, 2021 13:47
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@pmavridis pmavridis changed the title Fix issue with automatic RendererList culling option getting ignored [HDRP] Fix issue with automatic RendererList culling option getting ignored Dec 21, 2021
@pmavridis pmavridis changed the title [HDRP] Fix issue with automatic RendererList culling option getting ignored [HDRP] Fix issue with dynamic RendererList culling option getting ignored Dec 21, 2021
RemyUnity
RemyUnity approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see what could be tested more.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review January 13, 2022 12:50
@sebastienlagarde sebastienlagarde merged commit 1d7ecd8 into master Jan 13, 2022
@sebastienlagarde sebastienlagarde deleted the HDRP/fix_rendererlist branch January 13, 2022 12:51
sebastienlagarde pushed a commit that referenced this pull request Jan 13, 2022
@pmavridis @sebastienlagarde
[HDRP] Fix issue with dynamic RendererList culling option getting ign…
a891c80 
…ored #6659
sebastienlagarde added a commit that referenced this pull request Jan 13, 2022
@sebastienlagarde @alelievr
@JulienIgnace-Unity @anisunity @FrancescoC-unity @emilybrown1 @kecho @esdasuka @simonb-unity @eturquin @pmavridis @Vic-Cooper @JMargevics
[HDRP] Backport various PRs (#6742)
f89d0ff 
* Fix FBX Material

* [HDRP] Fix rendering when adding an incompatible platform to the project #6495

* Updated Physically Based Sky documentation with more warnings about warmup cost. #6498

* Fixed shaders craeted with the custom pass renderers template not being compatible with SRP batcher (case 1383694) (#6501)

* Fixed the fade in mode of the clouds not impacting the volumetric clouds shadows (case 1381652). #6511

* Avoid typed load on volumetric fog filtering on platforms that don't support it #6513

* Fixed the property name of screen weight distance (#6586)

* Documentation and images for custom mip for texture samplers (#6592)

* Documentation and images for custom mip for texture samplers

* Code review suggested changes.

* Fixed potential asymmetrical resource release in the volumetric clouds (case 1388218). #6600

* Fixed the intensity of the sky being reduced signficantly even if there is no clouds (case 1388279). #6601

* Fixed the rt screen space shadows not using the correct asset for allocating the history buffers. #6613

* Urp/fix 1378692 #6627

* Fixed a crash with render graph viewer #6629

* [HDRP] Fix tile/cluster debug for Decal and Fog #6635

* Minor rewording of PT doc. (#6637)

* Changed the behavior the max ray length for recursive rendering to match RTR and rasterization. #6643

* Fix (#6649)

* [HDRP] Fix issue with dynamic RendererList culling option getting ignored #6659

* Review new warmup cost section (#6683)

A few fixes applied to the changes in #6498 and #6323.

* Path fixes (#6692)

Updated incorrect menu paths.

* fixed typo "pratices" -> "practices" in ToC (#6699)

* fixed link to decal.md (#6700)

* Volume docs bugfixes (#6714)

* Volume docs bugfixes

Updates screenshots, menu paths and fixed some typos and inaccuracies.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* NeedMotionVectorForTransparent was checking for wrong flag #6719

* [HDRP][Tooltips] Fixed some tooltips for Local Volumetric Fog #6722

* [Fogbugz # 380357] Fixing negative overflowing of IES attenuation spline #6669

Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: esdasuka <soner.sen@gmail.com>
Co-authored-by: simonb-unity <94441789+simonb-unity@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: Jans Margevics <50581102+JMargevics@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelievr alelievr alelievr approved these changes

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@JulienIgnace-Unity JulienIgnace-Unity JulienIgnace-Unity approved these changes

@RemyUnity RemyUnity RemyUnity approved these changes

Assignees
No one assigned
Labels
backported-2022.1 HDRP SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmavridis @alelievr @sebastienlagarde @JulienIgnace-Unity @RemyUnity