update from base repo #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cover: Add Media Button when only colour is selected
* reset, delete nav menu items there is a missing state preservation when menus are changed on the menus editor component * fixing a bad merge * no invalidateCache and refactored according to review * revert change to getMergedItemIds * refactor according to self review * deletes query items, adds tests for new entity methods also adds changelog * refactored for properly deleteing entity ids from querries * updates tests * moved the REMOVE_ITEMS reducer to receive all query keys props @aduth * removes the need to send query on delete * updates some comments also removes cruft from a test * refactoring according to review - removes superfluous actions from deleteEntityRecords - treats invalidateCache properly - attempts to make lookups faster for items when removing querries * do not clear cache on delete * fixes test after reming superfluous actions from deleteEntityRecord * makes a proper POJO for removing items from queries and invalidates the cache after items are removed * fix changelog and add deleteQueryParams to deleteRecord * fixes test * Rename deleteQueryParams to query for consistency * Use the new deleteEntityRecord to delete menus (#22428) * adds delete menu with entity delete * updates the delete and removes the stateMenus * passes the new force query param * fix bug with resetting current menu after delete * fixes query param's type for consistency * comment linting, removed useless catch logic for deleteEntityRecord, removed useless string conversion * try implement error handling for delete * fixed the intentional typo and the unintentional one * updates and fixes according to review * rename remove items' action id collection * makes notices unique in menu editor * Update packages/core-data/src/queried-data/actions.js Co-authored-by: Enrique Piqueras <epiqueras@users.noreply.github.com> * fixes bugs introduced by renaming items to itemsIds in the remove items action also improves tests and made sure the notifications always have unique ids * lint * moves noticeId creation inside effect * updated according to review - test delete for final shape when generator is done - simplify filter removing items from query * lint Co-authored-by: Enrique Piqueras <epiqueras@users.noreply.github.com>
Outside of general updates to most questions (updated links, rephrasing, additional information), here's an overview of major changes in terms of new and removed questions: New questions: - What’s on the roadmap long term? - When was Gutenberg merged into WordPress? - When was Gutenberg started? Removed questions: - When will Gutenberg be merged into WordPress? - Why should I start using this once released? - What features will be available at launch? What does the post-launch roadmap look like? I'd love help with the "Are Custom Post Types still supported?" question as information feels out of date there but I couldn't find anything concrete recently.
Missed an empty fill
- Add support for text and background colors, line height, font size to the Post Title block. - Fix an issue causing the `HeadingLevelDropdown` to move to the top of the page when changing the heading level.
#24263) * Make "Attempt Block Recovery" the default option of block invalidation * Update docs * Fix e2e test for invalid block * Fix wrong contents in doc * Fix z-index issue when opening the resolve modal along with dropdown
* use optimised FlatList inside bottom-sheet
…#24253) * add lightWrapper to post author block * remove more unnecessary styles * post excerpt light wrapper and cleanup * update post comments for light wrapper and style cleanup * remove redundant definition
* Update code owners for rich text native implementations * Switch order of owners in order to have the following order: web, iOS, Android, iOS(2nd)
* Clarify custom link color documentation for themes. * Incorporate edits from @nosolosw
* i18n: Merge similar translation strings - tables See trac ticket https://core.trac.wordpress.org/ticket/47259 * table.test.js - updated translation strings * table.test.js - updated translation strings * fix table test * Update packages/e2e-tests/specs/editor/blocks/table.test.js Co-authored-by: Sören Wrede <soerenwrede@gmail.com> Co-authored-by: Sören Wrede <soerenwrede@gmail.com>
* Fix UnitControl invalid unit parsing. Add test. * Add tests for BoxControl * Fix useControlledState to handle controlled/uncontrolled swapping. Add Reset tests for BoxControl.
* Convert the <InvalidBlockWarning> component to function component with hooks * Add appliable comment
* Initial stab at throttled, hook-based AutosaveMonitor * Pass all tests * Simplify the logic and refactor use-scheduled-save to use-throttle * Further simplify useThrottle * Further simplify useThrottle * Simplify AutosaveMonitor * Fixed-schedule based AutosaveMonitor * Improve naming of things * Remove obsolete shouldThrottle from AutosaveMonitor * Roll back obsolete changes * Revisit some of the unit tests for AutosaveMonitor * Adjust unit tests * Fix a few flaky autosave e2e tests * Fix a few flaky autosave e2e tests * Update sessionStorage key used in e2e tests * Adjust the e2e test to throttle-less timer
…erter (#24285) * try for insertion point fix * use getPreviousBlockClientId selector
Add wide and full alignment support to post content block.
* Navigation screen: Add opt-in Navigation block rendering Allows themes to opt-in to having `wp_nav_menu()` render a complete Navigation block in place of the menu. This allows arbitrarily complex Navigation block structures can be used in an existing theme. When a theme declares `add_theme_support( 'block-nav-menus' )`, users are able to add non-link blocks to a Navigation using the Navigation screen. This block tree is stored as menu items and re-assembled into a Navigation block for display using `render_block()` in the frontend. Non-link blocks are stored using a menu item with type `'block'` which renders properly in `nav-menus.php`. This allows users to switch to a theme that does not support block menus and still see their data in WP Admin. * Navigation: Remove unused argument * Navigation: Fix phpunit tests * Shorten 'Gutenberg Block' label to 'Block' * Navigation: Add @return inline documentation * Navigation: Add label to content textarea * Navigation: Hide all non-content fields from Block menu items * Navigation: Fix loss of block content when saving menu in nav-menus.php
…24548) * add option for adding link in featured image * rename variable * fix php lint errors * change spaces to tabs * add alt text in featured image (editor)
Co-authored-by: Pinar Olguc <Pinar.Olguc@commencis.com>
* Remove button group and add tertiary styling to New template part button
* unset text color conditionally * logic fix
* Closes #24175. Adds icons and descriptions to Post blocks. * Addressed comments and removed spacing and extra lines in icon files. * Worked on spaces and enters again to fix errors. This is getting silly.
…e inserter menu (#24656)
This change specifies the content type and charset of the html passed into `DomDocument` as `utf-8`. Replaces the `mb_convert_encoding` call which encodes `UTF-8` as `HTML-ENTITIES` before handing off to `DomDocument`. This change avoids the need to later revert the encoding back to `UTF-8` afterwards using `mb_convert_encoding`. This secondary `mb_convert_encoding` call was converting not only the `UTF-8` characters that were converted earlier but also any pre-existing entity encoded html stored inside block content. This issue was originally raised here: Automattic/wp-calypso#44897 as I wasn't sure of the root cause at the time, originally thinking it may be because of the way [Jetpack is injecting](https://github.com/Automattic/jetpack/blob/dcfa5ca8bdfc31aacec107aec27bb24357d6cdac/modules/carousel/jetpack-carousel.php#L434) html into the [`data-image-description` attributes](https://github.com/Automattic/jetpack/blob/dcfa5ca8bdfc31aacec107aec27bb24357d6cdac/modules/carousel/jetpack-carousel.php#L485). There are more situations where this can be a problem such as encoded html entities existing inside block content then being decoded breaking html validation. Co-authored-by: Bernie Reiter <ockham@raz.or.at>
I was trying to find a way to display this component with a label and help text and found out much later of the existence of the ToggleControl component. I think that this addition can help other developers in a similar situation.
* Only update state if we have a valid reference * Only update state if we have a valid reference Co-authored-by: Janvo Aldred <janvoaldred@hotmail.com>
* Support drag and drop for submenus in Navigation block * Add a bunch of CSS to handle dragging style properly * Extract useIsDraggingWithin into its own hook * Add jsdoc
…nges (#24659) If we are trying to navigate away after making changes in the Site Editor, then we show an alert. Same way as we do in the Post Editor. Refactored `UnsavedChangesWarning` to accept a prop. This way we can decouple it from the Post Editor and use it for the Site Editor as well.
Typo corrected.
* add border for selected, child selected, and hover states on template part block
… and drop in List View (#24649) * Refactor block drop event handlers into a single hook * Add tests * Fix copy/pasta * Fix doc blocks * Fix typo with onFilesDrop * Use noop and add some helper comments
* Use a constant offset when Draggable uses a drag component * Use CSS for offset * Update comment * Use the block-toolbar-height for the chip offset Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Kai Hao <kevin830726@gmail.com>
…s not registered (#24559) Users can insert a generic version of the `core/embed` block from the block inserter, or choose a more specialized block variation (e.g. for Instagram, YouTube, etc). Furthermore, if a user inserts a plain URL, we also trigger our embed block creation behavior: We first create a generic `core/embed` block from that URL, and then analyze if we have a more specialized block variation. If we do, we transform the generic block into that block variation. A site admit might now choose to unregister certain block variations, in order to prevent users from inserting embeds of a certain type (e.g. they might choose to disallow WordPress embeds out of security concerns). In that case however, the URL insertion behavior will still attempt to insert a embed block variation for that specific embed type, even though that block variation is not available. We should thus check if a block variation of the `core/embed` is registered for the given embed type before attempting to transform the generic embed block into that variation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: