Fix block insertion place after clicking Browse All in the inline inserter#24285
Merged
ntsekouras merged 2 commits intomasterfrom Jul 30, 2020
Merged
Fix block insertion place after clicking Browse All in the inline inserter#24285ntsekouras merged 2 commits intomasterfrom
ntsekouras merged 2 commits intomasterfrom
Conversation
ntsekouras
added
[Type] Bug
youknowriad
reviewed
Jul 30, 2020
|
Size Change: +24 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.9 Beta/RC
youknowriad
approved these changes
Jul 30, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for the fix.
Should we try to add an e2e test for this use-case? Might not be the easiest one to write though.
youknowriad
pushed a commit
that referenced
this pull request
Aug 3, 2020
…erter (#24285) * try for insertion point fix * use getPreviousBlockClientId selector
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #24262
When you click
Browse Allbutton from inline inserter and then select a block, it inserts it after the previously selected block.Checklist: