Add option for adding link in featured image [ Latest Posts block ]#24548
Merged
ntsekouras merged 5 commits intomasterfrom Aug 18, 2020
Merged
Add option for adding link in featured image [ Latest Posts block ]#24548ntsekouras merged 5 commits intomasterfrom
ntsekouras merged 5 commits intomasterfrom
Conversation
|
Size Change: +107 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
draganescu
reviewed
Aug 14, 2020
packages/e2e-tests/fixtures/blocks/core__latest-posts__displayPostDate.json
Show resolved
Hide resolved
draganescu
requested changes
Aug 14, 2020
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Great work! There might be some SEO implications here with adding these links. Let's see some more opinions :)
14688d6 to
06db29a
Compare
06db29a to
48e7d4c
Compare
Contributor
|
There is an accessibility issue with this -- "Links do not have a discernible name" & should be updated to include an |
Contributor
Author
That would be great @robin-scott! 💯 I don't think there is an existing issue for this.. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #21530
This PR adds an option to
Latest Postsblock to add a link of the post tofeatured image.This is part of #20046 and ultimately the direction is to implement the
LatestPostsblock as a variation of theQueryblock, as described here: #24521.Checklist: