[RNMobile] Reduce spacing in slider#24161
Merged
lukewalczak merged 3 commits intomasterfrom Jul 28, 2020
Merged
Conversation
|
Size Change: +13 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
lukewalczak
added
the
Mobile App - i.e. Android or iOS
iamthomasbishop
approved these changes
Jul 24, 2020
iamthomasbishop
left a comment
iamthomasbishop
left a comment
There was a problem hiding this comment.
This looks good, and lines up with what I've got in Figma as far as I can tell. Thanks for taking care of it, Luke!
Contributor
|
Hey @lukewalczak, i'm wondering what is the difference between this PR and https://github.com/WordPress/gutenberg/pull/23580/files It seems like this should work the same as the reverted one |
Member
Author
|
Hmm that's interesting 🤔 are we sure then these changes introduced the regression? Do we have a specific case to test to confirm the current changes work properly? |
Member
Author
|
|
antonis
approved these changes
Jul 28, 2020
Member
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM! Nice work @lukewalczak !! 🎉 Tested it on both iOS and Android.
dratwas
approved these changes
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#2126
Fixes: wordpress-mobile/gutenberg-mobile#2501
How has this been tested?
Screenshots
Types of changes
Checklist: