Skip to content

[Mobile] Reduce spacing between label and slider control #23580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chipsnyder merged 1 commit into from
Jul 13, 2020
Merged

[Mobile] Reduce spacing between label and slider control #23580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/components/src/mobile/bottom-sheet/cellRowStyles.android.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.cellRowStyles {
min-height: 48px;
margin-bottom: -37px;
width: 100%;
justify-content: space-between;
}
6 changes: 6 additions & 0 deletions packages/components/src/mobile/bottom-sheet/cellRowStyles.ios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.cellRowStyles {
min-height: 48px;
margin-bottom: -27px;
width: 100%;
justify-content: space-between;
}
3 changes: 2 additions & 1 deletion packages/components/src/mobile/bottom-sheet/range-cell.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { withPreferredColorScheme } from '@wordpress/compose';
*/
import Cell from './cell';
import styles from './range-cell.scss';
import rowStyles from './cellRowStyles.scss';
import borderStyles from './borderStyles.scss';

class BottomSheetRangeCell extends Component {
Expand Down Expand Up @@ -179,7 +180,7 @@ class BottomSheetRangeCell extends Component {
<Cell
{ ...cellProps }
cellContainerStyle={ styles.cellContainerStyles }
cellRowContainerStyle={ styles.cellRowStyles }
cellRowContainerStyle={ rowStyles.cellRowStyles }
accessibilityRole={ 'none' }
value={ '' }
editable={ false }
Expand Down
7 changes: 0 additions & 7 deletions packages/components/src/mobile/bottom-sheet/range-cell.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,3 @@
flex-direction: column;
align-items: flex-start;
}

.cellRowStyles {
min-height: 48px;
margin-bottom: -13px;
width: 100%;
justify-content: space-between;
}