Avoid adding the CREATE suggestion in the results of contexts that don't support it#24222
Merged
youknowriad merged 1 commit intomasterfrom Jul 28, 2020
Merged
Avoid adding the CREATE suggestion in the results of contexts that don't support it#24222youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
youknowriad
added
[Type] Bug
youknowriad
added
the
Backport to WP 6.9 Beta/RC
|
Size Change: +8 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
fix/wrong-suggestions
branch
from
ce68f99 to
c54d7f4
Compare
ntsekouras
approved these changes
Jul 28, 2020
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
LGTM 👍 . Failing test was a timeout that doesn't seem to be related, so I re-run to be sure.
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24037
In the Navigation block, a suggestion that allows creating pages is shown but it's hidden in other contexts. Instead of just hide it from the results, this PR removes it entirely from the results.