Add a Git Diff to the output of the static checks job on failure#24154
Merged
Add a Git Diff to the output of the static checks job on failure#24154
Conversation
youknowriad
added
the
[Type] Automated Testing
|
Size Change: -1.03 MB (89%) 🏆 Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
debug/static-checks
branch
from
01aacfc to
5cd7bef
Compare
talldan
previously approved these changes
Jul 29, 2020
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
Nice idea, this would be really useful. 🎉
talldan
reviewed
Jul 29, 2020
Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
mcsf
reviewed
Aug 5, 2020
| "check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios\" \"wp-scripts check-licenses --dev\"", | ||
| "precheck-local-changes": "npm run docs:build", | ||
| "check-local-changes": "( git diff -U0 | xargs -0 node bin/process-git-diff ) || ( echo \"There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!\" && exit 1 );", | ||
| "check-local-changes": "( git diff -U0 | xargs -0 node bin/process-git-diff ) || ( echo \"There are local uncommitted changes after one or both of 'npm install' or 'npm run docs:build'!\" && git diff --exit-code && exit 1 );", |
Contributor
There was a problem hiding this comment.
Why --exit-code? From the documentation, I'm not sure how it helps, as we don't look at exit codes (and actually it could short-circuit that last && exit 1.
--exit-code
Make the program exit with codes similar to diff(1). That is, it exits with 1 if there were differences and 0 means no differences.
Contributor
There was a problem hiding this comment.
When I tested, git diff doesn't exit, it awaits user input.
Contributor
There was a problem hiding this comment.
Hm, I see. What about git --no-pager diff?
Contributor
There was a problem hiding this comment.
Did not know about that option, that looks like it'd be better, yep 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to understand why it's failing more quickly.