Fix: Crash after undo with top toolbar on#24629
Merged
jorgefilipecosta merged 1 commit intomasterfrom Aug 19, 2020
Merged
Conversation
jorgefilipecosta
added
the
[Type] Bug
jorgefilipecosta
requested review from
ellatrix and
youknowriad
as code owners
|
Size Change: +4 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 19, 2020
| clientIds !== null ? clientIds : getSelectedBlockClientIds(); | ||
| return map( getBlocksByClientId( ids ), ( block ) => block.name ); | ||
| return map( | ||
| compact( getBlocksByClientId( ids ) ), |
Contributor
There was a problem hiding this comment.
I wonder if the selector itself should clear the empty blocks. Not sure though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #24515
How has this been tested?
I repeated the steps described in #24515 and verified there was no crash anymore.