Refactor block drop event handlers into a single hook to support drag and drop in List View#24649
Merged
noisysocks merged 6 commits intomasterfrom Aug 21, 2020
Merged
Conversation
talldan
added
[Type] Task
|
Size Change: +525 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
talldan
requested review from
draganescu,
kevin940726,
noisysocks and
tellthemachines
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Tested with blocks and files and it works well in the editor; not sure how to test an HTML drop though.
| ); | ||
| } ); | ||
|
|
||
| it( 'adjusts the index blocks are dropped at when moved down under the same root block', () => { |
Contributor
There was a problem hiding this comment.
Hmm, is this too much of an implementation detail to be worth testing?
Contributor
Author
There was a problem hiding this comment.
e2e tests would definitely be better here, but there aren't any at the moment and they'd take a bit of investment.
This particular code has been buggy before (#24183), so a test seems beneficial.
| } ); | ||
|
|
||
| it( 'does nothing if the block has no matching file transforms', () => { | ||
| findTransform.mockImplementation( () => {} ); |
Contributor
There was a problem hiding this comment.
Why do we need to mock findTransform again here? And could we use noop defined at the top of the file?
Contributor
Author
There was a problem hiding this comment.
Hmm, I suppose not strictly required since jest.fn() also returns nothing, though I feel like having this line helps demonstrate that it's performing the inverse of the following test.
I switched it over to use noop and also added some comments.
Contributor
Author
@tellthemachines The easiest test I've found is to drag a link from another website. I'll update the testing instructions. |
tellthemachines
approved these changes
Aug 20, 2020
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Re-tested, HTML drop is working fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Separated from #23952.
Moves the code for handling block drop events into a separate react hook. This is required for #23952, as it'll allow List View to use the same drop event logic.
How has this been tested?
Types of changes
Non-breaking refactor.
Checklist: