Fix dragging multiple blocks dowards resulted in blocks inserted in wrong position#24183
Merged
youknowriad merged 2 commits intomasterfrom Jul 24, 2020
Merged
Conversation
talldan
changed the title
talldan
added
[Feature] Drag and Drop
|
Size Change: +10 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
youknowriad
pushed a commit
that referenced
this pull request
Jul 27, 2020
youknowriad
removed
the
Backport to WP 6.9 Beta/RC
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #24158.
When dragging and dropping blocks, if a block is dropped below where it originally was, the calculated insertion index has to take into that the dragged block was removed from the list above where we want to insert.
Previously, we did that by subtracting
1from the insertion index, as only a single block could be dragged at a time. Now that multiple blocks can be dragged, we need to use the number of blocks being dragged, which this PR does.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: