Removed svg fills and clips from svg code#24225
Merged
Conversation
|
Size Change: -44 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
There's one fill left here. Removing it just makes this a tiny bit smaller. No other effect.
MichaelArestad
approved these changes
Jul 27, 2020
Contributor
MichaelArestad
left a comment
MichaelArestad
left a comment
There was a problem hiding this comment.
There's one blank fill in the SVG element you could remove, but this is good to go. Nice work.
Missed an empty fill
mapk
force-pushed
the
update/post-date-block-remove-svg-fills
branch
from
325424e to
8bab5dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SVG still had fills and clip attributes, so I removed those allowing the icon to receive the proper hover state color.
How has this been tested?
Tested locally.
Screenshots
Types of changes
Non-breaking, SVG changes.
Checklist: