Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] require-default-props: fix config schema #3605

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[Fix] require-default-props: fix config schema #3605

merged 1 commit into from
Jul 20, 2023

Conversation

controversial
Copy link
Contributor

Fix #3604

Removes extraneous “allow” keyword from JSON schema definition. I couldn’t find any references to this keyword in JSON schema, nor documentation on its purpose, but it seems to break the TypeScript definitions generated in projects like eslint-define-config.

If the “allow” keyword has a purpose here that I’m not aware of, please feel free to close this PR.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #3605 (1a3a17a) into master (31282dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3605   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files         132      132           
  Lines        9295     9295           
  Branches     3397     3397           
=======================================
  Hits         9074     9074           
  Misses        221      221           
Impacted Files Coverage Δ
lib/rules/require-default-props.js 100.00% <ø> (ø)

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does match the intention in #3249 from what I can tell (also looking at the tests). Thanks!

@ljharb ljharb changed the title Fix JSON schema for require-default-props [Fix] require-default-props: fix config schema Jul 20, 2023
@ljharb ljharb merged commit 1a3a17a into jsx-eslint:master Jul 20, 2023
@controversial controversial deleted the patch-1 branch July 20, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: require-default-props JSON schema is incorrect
2 participants