-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] extract type parameters to a variable #3634
[Refactor] extract type parameters to a variable #3634
Conversation
Co-authored-by: HenryBrown0 <26250092+HenryBrown0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: HenryBrown0 <26250092+HenryBrown0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3634 +/- ##
==========================================
+ Coverage 97.47% 97.65% +0.17%
==========================================
Files 132 132
Lines 9360 9369 +9
Branches 3427 3429 +2
==========================================
+ Hits 9124 9149 +25
+ Misses 236 220 -16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall :-) just a few small tweaks and i'll land this, and you can rebase the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same throughout about uncovered lines
b4199ac
to
d08f761
Compare
d08f761
to
ca30f77
Compare
First of a two part pr to transition to
typeArguments
and fallback totypeParameters
for@typescript-eslint
v6
.This pr extracts type parameters to a variable before being used.
Second part can be found: #3629