-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-newline
: No newline between comments and jsx elements
#3493
[Fix] jsx-newline
: No newline between comments and jsx elements
#3493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3493 +/- ##
==========================================
- Coverage 97.57% 97.44% -0.13%
==========================================
Files 129 129
Lines 9200 9210 +10
Branches 3336 3341 +5
==========================================
- Hits 8977 8975 -2
- Misses 223 235 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases look great!
6217370
to
069314a
Compare
Fixes #3478 and #2926 and adds a couple more tests to show what was failing.
From what I can gather this should be the default behaviour. If not then then this can be hidden behind an option.
I was not sure about the behaviour of multiple Block comments before a Multiline Component. Decided the comments should stick together, based on sujan-s comment in #3478.