-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] no-unknown-property
: do not check fbs
elements
#3494
[Fix] no-unknown-property
: do not check fbs
elements
#3494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3494 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9200 9200
Branches 3336 3336
=======================================
Hits 8977 8977
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, i had no idea there were two of these. is that an exhaustive list? (i can't view the workplacae discussion, obv)
This is good to go as soon as we can add a test using fbs
.
Yeah, I'll add a test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll try to get another patch out in the next day or three.
no-unknown-property
: do not check fbs
elements
Currently
<fbs>
nodes are tagged with this linter warning:<fbt>
nodes are already exempt from this lint rule, and<fbs>
should be treated the same.Internal WP discussion: https://fb.workplace.com/groups/eslintfeedback/permalink/6064426636924059/