-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] sort-prop-types
: give errors on TS types
#3615
[New] sort-prop-types
: give errors on TS types
#3615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3615 +/- ##
=======================================
Coverage 97.63% 97.64%
=======================================
Files 132 132
Lines 9312 9337 +25
Branches 3400 3423 +23
=======================================
+ Hits 9092 9117 +25
Misses 220 220
|
Seems like there's some uncovered added lines; can you add tests that hit them? |
Looks like there's still a few failing tests. |
Yep, tried to debug this. It seems for |
@ljharb I have fixed the previous failing tests. |
ok, I rebased this, but I think this needs to go behind an option, otherwise it would be a breaking change. |
2b8d443
to
da1cc91
Compare
sort-prop-types
to give errors on ts typessort-prop-types
: give errors on TS types
329c495
to
121c89a
Compare
121c89a
to
cab612f
Compare
This PR is an attempt to solve #3578