-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-no-leaked-render
: invalid report if left side is boolean
#3746
[Fix] jsx-no-leaked-render
: invalid report if left side is boolean
#3746
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3746 +/- ##
==========================================
- Coverage 97.71% 97.58% -0.14%
==========================================
Files 133 133
Lines 9470 9480 +10
Branches 3469 3475 +6
==========================================
- Hits 9254 9251 -3
- Misses 216 229 +13 ☔ View full report in Codecov by Sentry. |
Not sure why the tests are failing here, @ljharb can you please have a look here once? |
Don't worry about the Automatic Rebase check, and the code coverage check isn't a "failure" as much as an indicator that this PR drops the coverage percentage. |
61d4a8a
to
d97e3ed
Compare
jsx-no-leaked-render
: invalid report if left side is boolean
Fixes #3719