Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-no-leaked-render: invalid report if left side is boolean #3746

Merged

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 3, 2024

Fixes #3719

@akulsr0 akulsr0 changed the title Akul/no leaked render boolean report [Fix] jsx-no-leaked-render: invalid report if left side is boolean May 3, 2024
@akulsr0

This comment was marked as resolved.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.58%. Comparing base (4467db5) to head (61d4a8a).
Report is 2 commits behind head on master.

❗ Current head 61d4a8a differs from pull request most recent head d97e3ed. Consider uploading reports for the commit d97e3ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3746      +/-   ##
==========================================
- Coverage   97.71%   97.58%   -0.14%     
==========================================
  Files         133      133              
  Lines        9470     9480      +10     
  Branches     3469     3475       +6     
==========================================
- Hits         9254     9251       -3     
- Misses        216      229      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akulsr0
Copy link
Contributor Author

akulsr0 commented May 9, 2024

Not sure why the tests are failing here, @ljharb can you please have a look here once?

@ljharb
Copy link
Member

ljharb commented May 9, 2024

Don't worry about the Automatic Rebase check, and the code coverage check isn't a "failure" as much as an indicator that this PR drops the coverage percentage.

@ljharb ljharb force-pushed the akul/no-leaked-render-boolean-report branch from 61d4a8a to d97e3ed Compare May 10, 2024 17:28
@ljharb ljharb changed the title [Fix] jsx-no-leaked-render: invalid report if left side is boolean [Fix] jsx-no-leaked-render: invalid report if left side is boolean May 10, 2024
@ljharb ljharb merged commit d97e3ed into jsx-eslint:master May 10, 2024
328 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: jsx-no-leaked-render report && in prop
2 participants