[New] forbid-component-props: add allowedForPatterns and disallowedForPatterns options
#3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb what do you think? |
ljharb
requested changes
Sep 11, 2024
lib/rules/forbid-component-props.js
Outdated
Comment on lines
145
to
147
| allowPatternList: typeof value === 'string' ? [] : value.allowedForPatterns || [], | ||
| disallowList: typeof value === 'string' ? [] : (value.disallowedFor || []), | ||
| disallowPatternList: typeof value === 'string' ? [] : value.disallowedForPatterns || [], |
There was a problem hiding this comment.
Suggested change
| allowPatternList: typeof value === 'string' ? [] : value.allowedForPatterns || [], | |
| disallowList: typeof value === 'string' ? [] : (value.disallowedFor || []), | |
| disallowPatternList: typeof value === 'string' ? [] : value.disallowedForPatterns || [], | |
| allowPatternList: [].concat(value.allowedForPatterns || []), | |
| disallowList: [].concat(value.disallowedFor || []), | |
| disallowPatternList: [].concat(value.disallowedForPatterns || []), |
altho i'm not sure why any of these would be able to be strings - doesn't the schema prevent that?
There was a problem hiding this comment.
Yeah, you're right about schema partially. There is also a string option there. Also, this rule has the default also for this rule, so that's why this code supports strings also.
|
Thanks a lot for the feedback, I will apply the changes. |
|
Honestly, not sure what to do with the "Automatic Rebase" action, didn't find any info in CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, issue was described here, but it was closed by another PR (although this PR implements different case).
So, this PR just reimplements
Regeximplementation withglobsas was suggested in one of the comments.