-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-boolean-value
: make error messages clearer
#3691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3691 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 133 133
Lines 9471 9462 -9
Branches 3472 3465 -7
==========================================
- Hits 9259 9250 -9
Misses 212 212 ☔ View full report in Codecov by Sentry. |
ljharb
requested changes
Feb 18, 2024
ljharb
force-pushed
the
fix/jsx-boolean-value
branch
from
March 3, 2024 23:51
4d83242
to
b16af66
Compare
ljharb
changed the title
[FIX] jsx-boolean-value error message makes clear
[Fix] Mar 3, 2024
jsx-boolean-value
: make error messages clearer
ljharb
approved these changes
Mar 3, 2024
ljharb
force-pushed
the
fix/jsx-boolean-value
branch
from
March 4, 2024 03:13
b16af66
to
6cb0f00
Compare
ljharb
closed this pull request by merging all changes
into
jsx-eslint:master
in
Mar 4, 2024
24d21ac
This was referenced May 24, 2024
This was referenced Oct 3, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #3675, jsx-boolean-value error message is not clear.
in current code, after setting never or always in the second option, if the modification is made not only to the first option but also to the second option, an error message containing the properties of the second option is displayed as shown below.
i think this is not make sense, so change the error message include single prop that has error. so fixed test case is it
other test case change is because of message format change