-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] boolean-prop-naming
: avoid a crash with a non-TSTypeReference type
#3718
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
developer-bandi:fix/boolean-prop-naming-2
Apr 11, 2024
Merged
[Fix] boolean-prop-naming
: avoid a crash with a non-TSTypeReference type
#3718
ljharb
merged 1 commit into
jsx-eslint:master
from
developer-bandi:fix/boolean-prop-naming-2
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3718 +/- ##
==========================================
- Coverage 97.76% 97.71% -0.05%
==========================================
Files 133 133
Lines 9467 9470 +3
Branches 3467 3469 +2
==========================================
- Hits 9255 9254 -1
- Misses 212 216 +4 ☔ View full report in Codecov by Sentry. |
ljharb
force-pushed
the
fix/boolean-prop-naming-2
branch
from
April 10, 2024 05:27
3cdaed2
to
4467db5
Compare
ljharb
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
ljharb
changed the title
[Fix] boolean-prop-naming: TSIntersectionType with TSTypeReference And TSLiteral reference Error
[Fix] Apr 11, 2024
boolean-prop-naming
: avoid a crash with a non-TSTypeReference type
2 tasks
This was referenced Jun 18, 2024
This was referenced Oct 4, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #3717
I think cause of bug is no concider below case
To explain in detail, if the type is not
TSTypeReference
(literal type, etc.), a reference error appears to have occurred because there is no typeName property.Therefore, if it is not the corresponding type, the type has been modified to be used as is rather than taken from objectTypeAnnotations.