Repository navigation
cluster: absorb Widget XML exit batches A/B/C (#2841 #2843 #2854) - #2862
Merged
Merged
Conversation
…2831) Commit modern widgets/<stem>/ component packages for baseWidgets, defaultLanguage, event, openGraph, and twitterSummaryCards (8 widgets). Add PSWidgetXmlDualShip + tests; shim prefers widgets/ modern over XML. Keep install Widget XML (no mass-delete). Fix native page install mixed-case mapping lookup for package suite green. Fixes #2831 Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
…, CLI exit, shared resolve) - PSLegacyDefinitionXmlShim: sort modern manifests with Locale.ROOT (match dual-ship) - PSWidgetXmlDualShip.main: unknown commands print usage and exit(1) - DualShip.resolvePackageRelative delegates to PSWidgetXmlCompiler (enhanced with backslash/leading-slash normalize) > Co-Authored by Grok Code using grok with agent night-issue-prs-followup.
…2832) Commit modern widgets/<stem>/ component packages for high-traffic (#2772) and residual long-tail (#2789) product packages (20 widgets / 14 packages). Extend PSWidgetXmlDualShip batch B constants, materialize, and parity tests. Keep install Widget XML (no mass-delete). Stacks on batch A (#2831 / PR #2841). Fixes #2832 Also covers #2842 high-traffic dual-ship roots Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
…2844) Materialize + commit modern widgets/<stem>/ authoring roots for remaining product packages after batches A/B (19 widgets / 19 packages): auto-lists, blog companions, comments/liked/commentForm, imageSlider, cookieConsent, jquery/jqueryUI, registration/secureLogin, Result/Redirect. - PSWidgetXmlDualShip.BATCH_C_* + materializeModernBatchC + CLI - PSWidgetXmlDualShipTest product batch C parity + batch disjointness - Keep install Widget XML (no mass-delete); perc.Test still residual (#2830) - Cumulative modern dual-ship roots: 47 widgets (product gap excl. Test: 0) Parent: #2630 · Stacked on batch B PR #2843 (includes A #2841) Fixes #2844 > Co-Authored by Grok Build using grok-4.5 with agent main.
Address Kilo review: resolve widgets/ via PSWidgetXmlDualShip.WIDGETS_DIR_NAME. > Co-Authored by Grok Code using grok with agent night-issue-prs-followup.
natechadwick-intsof
added
operator:grok
natechadwick
approved these changes
Aug 11, 2026
This was referenced Aug 11, 2026
Closed
natechadwick
pushed a commit
that referenced
this pull request
Aug 11, 2026
* feat(perc-packages): stop shipping Widget def XML batch A (base/core) (#2883) Remove committed sys__UserDependency--rxconfig/Widgets/*.xml from batch A product packages (baseWidgets, defaultLanguage, event, openGraph, twitter) now that modern widgets/<stem>/ roots exist (#2862). Add PSWidgetXmlInstallEmitter so package build materializes install Widget XML from modern for modern-only packages (deployer/PSWidgetDao wire format). Keep PSLegacyDefinitionXmlShim and upgrade compilers. Document 48→40 committed Widget def XML count. Fixes #2883 Refs #2630 #2626 #2862 > Co-Authored by Grok Build using grok-4.5 with agent main. * feat(perc-packages): stop shipping Widget def XML batch B (high-traffic) (#2884) Remove committed sys__UserDependency--rxconfig/Widgets/*.xml from batch B product packages (high-traffic + residual long-tail, 20 widgets / 14 pkgs) now that modern widgets/<stem>/ roots exist (#2862). Add PSWidgetXmlInstallEmitter so package build materializes install Widget XML from modern for modern-only packages (deployer/PSWidgetDao wire format). Leave batch A dual-ship committed XML (sibling #2883). Keep PSLegacyDefinitionXmlShim and upgrade compilers. Document 48→28 committed Widget def XML count. Fixes #2884 Refs #2630 #2626 #2862 > Co-Authored by Grok Build using grok-4.5 with agent main. * feat(perc-packages): stop shipping Widget def XML batch C + M1 refresh (#2885) Remove committed sys__UserDependency--rxconfig/Widgets/*.xml from batch C product packages (19 widgets / 19 packages) now that modern widgets/<stem>/ roots exist (#2862). Add PSWidgetXmlInstallEmitter so package build materializes install Widget XML from modern for modern-only packages. Refresh definition-xml-shim-removal-criteria M1 snapshot (48→29) and widget inventory; waive perc.Test. Keep PSLegacyDefinitionXmlShim. Fixes #2885 Refs #2630 #2626 #2852 #2862 > Co-Authored by Grok Build using grok-4.5 with agent main. * fix(perc-packages): batch C second materialize no-op assert (#2897) Mirror batch A/B: after first materializeInstallWidgetXml, assert a second call returns 0 so overwrites of already-present install XML are caught. Evidence: cd modules/perc-packages; ../../mvnw.cmd clean install ΓåÆ BUILD SUCCESS > Co-Authored by Grok CLI using grok-4 with agent night-issue-prs-post-work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same-file thrash absorption for overnight dual-ship Widget XML exit batches A/B/C. Three stacked PRs repeatedly rewrote the same dual-ship registry, inventory docs, and modern
widgets/<stem>/roots. This cluster merges them oldest-first againstmainso human review/merge is one PR.Thrash files (high-signal)
modules/perc-packages/src/main/java/com/percussion/packages/widgetxml/PSWidgetXmlDualShip.javamodules/perc-packages/src/test/java/com/percussion/packages/widgetxml/PSWidgetXmlDualShipTest.javamodules/perc-packages/src/main/java/com/percussion/packages/widgetxml/PSWidgetXmlPackageCompiler.javamodules/perc-packages/src/main/java/com/percussion/packages/shim/PSLegacyDefinitionXmlShim.javadocs/ai-generated/tasks/template-assembler-normalization/dual-ship-widget-xml-exit.mddocs/ai-generated/tasks/template-assembler-normalization/widget-xml-inventory.mddocs/ai-generated/tasks/template-assembler-normalization/dual-run-legacy-definition-xml-shim.mdmodules/perc-packages/src/main/resources/Packages/**/widgets/**Supersedes
fix/issue-2831-widget-xml-exit-batch-aPSWidgetXmlDualShipfoundationfix/issue-2832-widget-xml-exit-batch-bfix/issue-2844-widget-xml-exit-batch-cWIDGETS_DIR_NAMEfollow-upTree content matches tip of #2854 (empty
git diffvsorigin/fix/issue-2844-widget-xml-exit-batch-c).Closes product work for #2831, #2832, #2844 (issues already closed by overnight issue agents).
Not absorbed (no thrash threshold)
ContentExplorerShell.tsxbut only 2 MERGEABLE members (cluster_min_prs=3).Test plan / gates evidence
cd modules\perc-packages ..\..\mvnw.cmd clean installAfter each absorb (A, B, C) and final:
modules/perc-packagesonly (docs + perc-packages sources)Product documentation
docs/ai-generated/; install XML retained; no operator-facing product-docs change in these batchesChecklist
Operator: Grok: night-issue-prs (model grok-4.5)