Skip to content

docs(#2835): definition-XML shim removal criteria + inventory - #2853

Merged
natechadwick merged 1 commit into
mainfrom
fix/issue-2835-def-xml-shim-criteria
Aug 11, 2026
Merged

docs(#2835): definition-XML shim removal criteria + inventory#2853
natechadwick merged 1 commit into
mainfrom
fix/issue-2835-def-xml-shim-criteria

Conversation

@natechadwick-intsof

@natechadwick-intsof natechadwick-intsof commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Phase 5 slice 3 of #2632 (epic #2626): document hard gates for removing the legacy definition-XML dual-run runtime shim, plus a 2026-08-10 inventory of dual-run call sites.

Decision: criteria are not met — leave PSLegacyDefinitionXmlShim and related dual-run loaders in place. Residual #2852 tracks the actual deletion PR when M1–M3 + G1–G6 have evidence.

Delivered

  • New: docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md
    • Metrics M1–M3 (product XML, runtime loads, customer upgrade window)
    • Test/CI gates G1–G6
    • Time-box rules (no mass-delete)
    • Grep/tree inventory (shim package, PSWidgetDao, GadgetRegistry dual-load, 48 product Widget XMLs / 39 package trees)
  • Cross-links from dual-run policy, ADR-004, plan Phase 5, README, dual-ship doc

Explicit non-goals in this PR

  • No code deletion of customer-facing shim
  • No product Widget XML mass-delete (Phase 3 / M1)

Test plan

  • Docs-only review: criteria readable; inventory matches tree snapshot on branch
  • N/A Maven — no production/test source or pom.xml changes

Product documentation

  • N/A — engineering criteria under docs/ai-generated/tasks/; no operator-facing product behavior change in this PR. Operator dual-run checklist remains in dual-run doc (still required).

Build evidence (C3)

  • modules_built: none (docs-only)
  • build_evidence: No Maven modules changed; standalone clean install not required
  • downstream_checked: none (no API/type changes)

Residual

Operator

Operator: Grok: night-issue-prs (model grok-4.5)

Parent tracker: #2632 · Epic: #2626

Fixes #2835
Partial: residual #2852 for code deletion when criteria met

Co-Authored by Grok Build using grok-4.5 with agent main.

@natechadwick-intsof natechadwick-intsof added documentation Improvements or additions to documentation 8.2 This issue found in 8.2 release operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow model:grok-4.5 Grok 4.5 model labels Aug 10, 2026
This was referenced Aug 10, 2026
Closed
Open
Closed
Open
@kilo-code-bot

kilo-code-bot Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md — New file
  • docs/ai-generated/tasks/template-assembler-normalization/README.md — 1 line added
  • docs/ai-generated/tasks/template-assembler-normalization/adr/004-no-definition-xml-packaging.md — 1 line changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-run-legacy-definition-xml-shim.md — 19 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-ship-page-template-retirement.md — 2 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/plan.md — 2 lines changed
Previous Review Summaries (2 snapshots, latest commit a4015c2)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a4015c2)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md — New file
  • docs/ai-generated/tasks/template-assembler-normalization/README.md — 1 line added
  • docs/ai-generated/tasks/template-assembler-normalization/adr/004-no-definition-xml-packaging.md — 1 line changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-run-legacy-definition-xml-shim.md — 19 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-ship-page-template-retirement.md — 2 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/plan.md — 2 lines changed

Previous review (commit bbb3f87)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md — New file
  • docs/ai-generated/tasks/template-assembler-normalization/README.md — 1 line added
  • docs/ai-generated/tasks/template-assembler-normalization/adr/004-no-definition-xml-packaging.md — 1 line changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-run-legacy-definition-xml-shim.md — 19 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/dual-ship-page-template-retirement.md — 2 lines changed
  • docs/ai-generated/tasks/template-assembler-normalization/plan.md — 2 lines changed

Reviewed by step-3.7-flash · Input: 71.3K · Output: 12K · Cached: 507.5K

Review guidance: REVIEW.md from base branch main

natechadwick
natechadwick previously approved these changes Aug 10, 2026
View reviewed changes
@natechadwick
natechadwick enabled auto-merge (squash) August 10, 2026 23:43
@natechadwick-intsof

natechadwick-intsof commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Overnight follow-up: Rebased onto origin/main; resolved plan.md Phase 5 conflict by keeping both the #2835 shim-removal criteria hard gate and the #2834 XSL cookbook done notes.

Force-with-lease: a4015c23ee. Docs-only — no Maven modules changed.

Co-Authored by Grok Code using grok with agent night-issue-prs-followup.

@natechadwick-intsof
natechadwick-intsof force-pushed the fix/issue-2835-def-xml-shim-criteria branch from bbb3f87 to a4015c2 Compare August 11, 2026 00:30
@natechadwick-intsof natechadwick-intsof mentioned this pull request Aug 11, 2026
Merged
4 of 5 tasks
@natechadwick-intsof
docs(#2835): definition-XML shim removal criteria + dual-run inventory
e0cd30b 
Phase 5 (#2632 / epic #2626) hard gate: metrics M1-M3, test gates G1-G6,
time-box, and 2026-08-10 grep/tree inventory. Criteria unmet — leave
PSLegacyDefinitionXmlShim and related dual-run loaders; residual for
deletion when evidence exists. Cross-link dual-run policy, ADR-004, plan,
README.

Fixes #2835

> Co-Authored by Grok Build using grok-4.5 with agent main.
@natechadwick-intsof
natechadwick-intsof force-pushed the fix/issue-2835-def-xml-shim-criteria branch from a4015c2 to e0cd30b Compare August 11, 2026 02:38
@natechadwick-intsof

natechadwick-intsof commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto origin/main (commit e0cd30b70c): resolved content conflict in dual-run-legacy-definition-xml-shim.md Exit criteria — kept main's widget dual-ship batch A (#2831) inventory progress and this PR's criteria-doc metrics/gates language + "Do not mass-delete" rule.

Docs-only; no Maven modules.

Co-Authored by Grok Code using grok with agent night-issue-prs-followup.

@natechadwick
natechadwick merged commit bade47f into main Aug 11, 2026
5 checks passed
@natechadwick
natechadwick deleted the fix/issue-2835-def-xml-shim-criteria branch August 11, 2026 02:49
@natechadwick-intsof natechadwick-intsof mentioned this pull request Aug 11, 2026
Closed
3 tasks
This was referenced Sep 12, 2026
Closed
Merged
natechadwick pushed a commit that referenced this pull request Sep 19, 2026
@natechadwick-intsof
docs(normalization): close Phase 5 status, link operator help (#2632) (…
0cb7ac3 
…#4594)

README status table still showed Phase 1 in progress and Phases 2-5
blocked, although Phases 0-4 are closed and all six Phase 5 docs slices
merged (#2845/#2851/#2853/#4437/#4442/#4445). Mark phases done, point
operators at the live product-docs help pages, and keep the #2852
shim-removal hard gate explicit.

Fixes #2632
Parent: #2626

> Co-Authored by OpenCode 1.18.31 using muse-spark-1.3-contributor-free with agent night-issue-prs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natechadwick natechadwick natechadwick approved these changes

Assignees

No one assigned

Labels

8.2 This issue found in 8.2 release documentation Improvements or additions to documentation model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issue 2632 slice 3: definition-XML shim removal criteria + residual

2 participants

@natechadwick-intsof @natechadwick