Phase 5 residual: remove definition-XML dual-run shim when criteria met

[natechadwick-intsof]

Parent

Parent: #2632
Grandparent: #2626
Slice residual from: #2835

Goal

When definition-XML shim removal criteria are met with evidence, remove (or hard-disable) the time-boxed dual-run runtime path and rewire consumers to modern-only selection. Do not start this work until the criteria doc says M1–M3 + G1–G6 pass.

Canonical criteria + inventory:
docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md

Prerequisites (hard)

• M1: product Packages no longer ship Widget/Page/Gadget definition XML (ADR-004) — Phase 3 [8.2] Template/assembler Phase 3: eliminate product definition XML packaging #2630 residuals
• M2: runtime metrics / support inventory show zero (or waived) legacy definition-XML loads
• M3: customer upgrade window closed or residual customers documented with waiver
• G1–G6 test/CI gates as listed in criteria doc

In scope (when prerequisites met)

1. Rewire production consumers (PSWidgetDao and any package-root loaders) to modern Component Package Manifest; fail clearly when modern absent (no silent invent)
2. Delete or hard-disable PSLegacyDefinitionXmlShim legacy fallback only after consumers no longer need it; keep upgrade-input compilers (PSWidgetXml*, page/gadget compilers) unless a separate decision retires them
3. Gadget WebUI dual-load (GadgetRegistry modern → legacy XML) only if M2 covers gadgets in the same change set — otherwise leave a focused residual
4. Unit/integration tests for modern-only behavior; module standalone mvnw clean install on each changed module
5. Update dual-run + criteria docs status to retired/met; product-docs only if operator-facing load behavior changes

Out of scope

• Unattended mass deletion without metrics evidence
• Product Widget XML package deletion before M1 (that is Phase 3 work)
• Page dual-ship code path retirement (see dual-ship-page-template-retirement.md — separate checklist)
• Phase 3 package residual work tracked under [8.2] Template/assembler Phase 3: eliminate product definition XML packaging #2630 children

Acceptance

• Criteria doc checklist section all checked with linked evidence
• Legacy dual-run runtime path gone or hard-disabled; modern-only load green
• Tests + per-module clean install evidence
• Docs updated; [8.2] Template/assembler Phase 5: deprecation cleanup and help #2632 / [8.2] Template & assembler model normalization (epic) #2626 Agent progress updated

Modules

modules/perc-packages (required); likely projects/sitemanage (widget DAO); possibly WebUI (gadget dual-load)

Labels

p2 · 8.2 · enhancement

Leave unassigned.

Refs #2835 #2632 #2626 #2630

Co-Authored by Grok Build using grok-4.5 with agent main.

[natechadwick-intsof]

Filed from #2835 / PR #2853. Criteria snapshot: \docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md\ (criteria not met as of 2026-08-10).

Co-Authored by Grok Build using grok-4.5 with agent main.

[natechadwick-intsof]

Triage note: M2 dual-run evidence slices filed under #2630 as #3130 / #3131 / #3132. This issue (#2852) remains blocked until criteria M1–M3 + G1–G6 pass — do not remove shim tonight.

Co-Authored by Grok using grok-4.5 with agent night-issue-triage.

[natechadwick-intsof]

Criteria status refresh (2026-08-12 01:11 -04:00) from #3132 / PR #3137:

Canonical doc: docs/ai-generated/tasks/template-assembler-normalization/definition-xml-shim-removal-criteria.md (Status snapshot 2026-08-12).

ID	Status
M1	PASS (product non-waived Widget def XML = 0 on main; perc.Test waived; cluster #2897)
M2	PARTIAL / FAIL overall — #3024/#3025 on main; product defaults #3130 and metrics harness #3131 still open; no zero-legacy runtime window
M3	FAIL — customer upgrade window still open by design
G1–G6	G4 Widget PASS; G2 partial; G1/G3/G5 N/A until removal PR; G6 pass for current Path surfaces

This issue (#2852) remains BLOCKED. Do not implement shim / dual-run deletion until M1–M3 + G1–G6 all PASS (or waived with owner + sunset). PARTIAL M2 infrastructure is not ready-to-remove.

Operator checklist (H2 qa-up + product install + how to read metrics): dual-run-legacy-definition-xml-shim.md.

Co-Authored by Grok Build using grok-4.5 with agent main.