issue 2632 slice 3: definition-XML shim removal criteria + residual

[natechadwick-intsof]

Parent

Parent: #2632
Grandparent: #2626

Slice goal

Document shim removal criteria for legacy definition-XML dual-run (metrics, gates, time-box). Do not delete the runtime shim in this slice unless criteria are already met with evidence; otherwise file a residual issue and leave shim in place.

In scope

1. Criteria doc: zero product XML loads metric, customer upgrade window, test gates
2. Grep/inventory snapshot of remaining definition-XML dual-run call sites
3. If criteria unmet: open residual issue (do not invent mega-delete)
4. If criteria met with evidence: thin removal PR only for proven-dead paths + tests

Out of scope

• Unattended mass deletion of customer-facing shim without metrics
• Phase 3 package residual work ([8.2] Template/assembler Phase 3: eliminate product definition XML packaging #2630 children)

Acceptance

• Criteria doc committed
• Either shim residual filed OR proven-safe thin removal with tests
• Update [8.2] Template/assembler Phase 5: deprecation cleanup and help #2632 / [8.2] Template & assembler model normalization (epic) #2626 Agent progress
• Module clean install if code touched

Modules

docs; optionally modules/perc-packages / system if thin removal proven

Refs #2632 #2626 #2630

[natechadwick-intsof]

night-issue-prs: starting work on definition-XML shim removal criteria + inventory (slice 3 of #2632).

Co-Authored by Grok Build using grok-4.5 with agent main.

[natechadwick-intsof]

Work complete for this slice:

• Criteria + inventory: PR docs(#2835): definition-XML shim removal criteria + inventory #2853
• Criteria unmet — shim remains
• Residual for deletion when metrics allow: Phase 5 residual: remove definition-XML dual-run shim when criteria met #2852
• Parent progress updated on [8.2] Template/assembler Phase 5: deprecation cleanup and help #2632 / [8.2] Template & assembler model normalization (epic) #2626

Closing as slice delivered (criteria doc + residual). Residual #2852 remains open for code removal.

Co-Authored by Grok Build using grok-4.5 with agent main.

[natechadwick-intsof]

Slice complete: criteria doc + inventory in PR #2853; residual #2852 for shim removal when criteria met. No open agent work left on #2835 itself.

Co-Authored by Grok Build using grok-4.5 with agent main.