Repository navigation
feat(perc-packages): dual-ship Widget XML exit batch A modern roots (#2831) - #2841
Closed
natechadwick-intsof wants to merge 2 commits into
Closed
natechadwick-intsof wants to merge 2 commits into
natechadwick-intsof wants to merge 2 commits into
Conversation
natechadwick-intsof
added
operator:grok
This was referenced Aug 10, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (26 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit ee99b20)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ee99b20)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (26 files)
Reviewed by laguna-s-2.1:free · Input: 472.9K · Output: 20.3K · Cached: 932.2K Review guidance: REVIEW.md from base branch |
1 task done
…2831) Commit modern widgets/<stem>/ component packages for baseWidgets, defaultLanguage, event, openGraph, and twitterSummaryCards (8 widgets). Add PSWidgetXmlDualShip + tests; shim prefers widgets/ modern over XML. Keep install Widget XML (no mass-delete). Fix native page install mixed-case mapping lookup for package suite green. Fixes #2831 Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
…, CLI exit, shared resolve) - PSLegacyDefinitionXmlShim: sort modern manifests with Locale.ROOT (match dual-ship) - PSWidgetXmlDualShip.main: unknown commands print usage and exit(1) - DualShip.resolvePackageRelative delegates to PSWidgetXmlCompiler (enhanced with backslash/leading-slash normalize) > Co-Authored by Grok Code using grok with agent night-issue-prs-followup.
natechadwick-intsof
force-pushed
the
fix/issue-2831-widget-xml-exit-batch-a
branch
from
August 11, 2026 00:26
ee99b20 to
2e5d8b7
Compare
Collaborator
Author
|
Overnight follow-up:
Force-with-lease push complete.
|
natechadwick-intsof
added a commit
that referenced
this pull request
Aug 11, 2026
…2832) Commit modern widgets/<stem>/ component packages for high-traffic (#2772) and residual long-tail (#2789) product packages (20 widgets / 14 packages). Extend PSWidgetXmlDualShip batch B constants, materialize, and parity tests. Keep install Widget XML (no mass-delete). Stacks on batch A (#2831 / PR #2841). Fixes #2832 Also covers #2842 high-traffic dual-ship roots Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main.
natechadwick-intsof
added a commit
that referenced
this pull request
Aug 11, 2026
…2844) Materialize + commit modern widgets/<stem>/ authoring roots for remaining product packages after batches A/B (19 widgets / 19 packages): auto-lists, blog companions, comments/liked/commentForm, imageSlider, cookieConsent, jquery/jqueryUI, registration/secureLogin, Result/Redirect. - PSWidgetXmlDualShip.BATCH_C_* + materializeModernBatchC + CLI - PSWidgetXmlDualShipTest product batch C parity + batch disjointness - Keep install Widget XML (no mass-delete); perc.Test still residual (#2830) - Cumulative modern dual-ship roots: 47 widgets (product gap excl. Test: 0) Parent: #2630 · Stacked on batch B PR #2843 (includes A #2841) Fixes #2844 > Co-Authored by Grok Build using grok-4.5 with agent main.
4 of 5 tasks
Collaborator
Author
|
Superseded by #2862 — same-file thrash absorption (Widget XML dual-ship exit batches A/B/C); do not merge this PR. Content fully absorbed into the cluster branch. |
Collaborator
Author
|
Closed as superseded by #2862 (night-issue-prs cluster thrash absorption). |
natechadwick
pushed a commit
that referenced
this pull request
Aug 11, 2026
) * feat(perc-packages): dual-ship Widget XML exit batch A modern roots (#2831) Commit modern widgets/<stem>/ component packages for baseWidgets, defaultLanguage, event, openGraph, and twitterSummaryCards (8 widgets). Add PSWidgetXmlDualShip + tests; shim prefers widgets/ modern over XML. Keep install Widget XML (no mass-delete). Fix native page install mixed-case mapping lookup for package suite green. Fixes #2831 Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main. * fix(perc-packages): address PR #2841 review threads (Locale.ROOT sort, CLI exit, shared resolve) - PSLegacyDefinitionXmlShim: sort modern manifests with Locale.ROOT (match dual-ship) - PSWidgetXmlDualShip.main: unknown commands print usage and exit(1) - DualShip.resolvePackageRelative delegates to PSWidgetXmlCompiler (enhanced with backslash/leading-slash normalize) > Co-Authored by Grok Code using grok with agent night-issue-prs-followup. * feat(perc-packages): dual-ship Widget XML exit batch B modern roots (#2832) Commit modern widgets/<stem>/ component packages for high-traffic (#2772) and residual long-tail (#2789) product packages (20 widgets / 14 packages). Extend PSWidgetXmlDualShip batch B constants, materialize, and parity tests. Keep install Widget XML (no mass-delete). Stacks on batch A (#2831 / PR #2841). Fixes #2832 Also covers #2842 high-traffic dual-ship roots Parent #2630 > Co-Authored by Grok Build using grok-4.5 with agent main. * feat(perc-packages): dual-ship Widget XML exit batch C modern roots (#2844) Materialize + commit modern widgets/<stem>/ authoring roots for remaining product packages after batches A/B (19 widgets / 19 packages): auto-lists, blog companions, comments/liked/commentForm, imageSlider, cookieConsent, jquery/jqueryUI, registration/secureLogin, Result/Redirect. - PSWidgetXmlDualShip.BATCH_C_* + materializeModernBatchC + CLI - PSWidgetXmlDualShipTest product batch C parity + batch disjointness - Keep install Widget XML (no mass-delete); perc.Test still residual (#2830) - Cumulative modern dual-ship roots: 47 widgets (product gap excl. Test: 0) Parent: #2630 · Stacked on batch B PR #2843 (includes A #2841) Fixes #2844 > Co-Authored by Grok Build using grok-4.5 with agent main. * fix(perc-packages): use WIDGETS_DIR_NAME in shim dual-ship paths (#2854) Address Kilo review: resolve widgets/ via PSWidgetXmlDualShip.WIDGETS_DIR_NAME. > Co-Authored by Grok Code using grok with agent night-issue-prs-followup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dual-ship Widget XML exit batch A (#2831 / parent #2630): product packages for baseWidgets + defaultLanguage + event/openGraph/twitter now author modern
widgets/<stem>/component-package.json+ template sources (8 widgets / 5 packages). Install still dual-ships legacysys__UserDependency--rxconfig/Widgets/*.xml(no mass-delete; shim/native widget install still residual).PSWidgetXmlDualShip(materialize modern, batch A constants, load/compile modern)PSLegacyDefinitionXmlShimpreferswidgets/<stem>/component-package.jsonover legacy XMLdocs/ai-generated/tasks/template-assembler-normalization/dual-ship-widget-xml-exit.mdPSPageXmlNativeInstall) so module clean install stays greenResidual Widget XML count: still 48 definition XMLs on disk (install path). Modern dual-ship authoring roots: 8. Remaining product widgets without modern roots: ~40 (excl. counting nuance of perc.Test).
Operator: Grok: night-issue-prs (model grok-4.5)
Parent tracker: #2630 · Grandparent: #2626
Fixes #2831
Test plan
cd modules/perc-packages && ../../mvnw.cmd clean install(standalone)PSWidgetXmlDualShipTestproduct batch A parity + shim modern preference.ppkgfor batch A packages (install XML retained)Build evidence (C3)
modules/perc-packagescd modules/perc-packages; ..\..\mvnw.cmd clean install→ BUILD SUCCESS; Tests run: 104, Failures: 0, Errors: 0Product documentation
docs/ai-generated/tasks/template-assembler-normalization/.