Skip to content

feat(WebUI): Explorer action toolbar + context menu enablement (#2849) - #2855

Merged
natechadwick merged 2 commits into
mainfrom
feat/issue-2849-explorer-action-toolbar-context-menu
Aug 11, 2026
Merged

natechadwick merged 2 commits into
mainfrom
feat/issue-2849-explorer-action-toolbar-context-menu

Conversation

@natechadwick-intsof

Copy link
Copy Markdown
Collaborator

Summary

Implements #2849 (slice 2 of #2407 / grandparent #2400): product Explorer server action toolbar + item/folder context menu composition from existing rest/actions, with client-side enablement helpers that hide desktop-only / non-web-executable actions and route CONTEXTMENU roots to the popup only.

Changes

  • actionEnablement.ts: pure helpers (filterToolbarActions / filterContextMenuActions, desktop URL detection, CLIENT sentinel handling, surface rules).
  • ContentExplorerShell: apply enablement after catalog + workflow merge; load full cascading tree for folder context (drop item=true which only kept flat MENUITEM roots).
  • Vitest: actionEnablement.test.ts (11) + shell test for toolbar filter + context-menu mount.
  • Playwright: us1-core-explorer asserts toolbar + right-click context menu when rows exist.
  • product-docs: new Content Explorer admin page + index/sites links.

Out of scope (unchanged)

Parent / slices

Issue Role
#2400 Grandparent DCE parity epic
#2407 Parent shell composition
#2849 This PR (slice 2)
#2848 Slice 1 display formats (done)
#2850 Slice 3 search + Playwright chrome

Test plan

Product documentation

  • Updated pages under product-docs/ (8.2/admin/content-explorer.md, admin index, sites related link)

Build evidence (C3)

  • modules_built: WebUI
  • build_evidence: cd WebUI; ..\mvnw.cmd clean install → BUILD SUCCESS; Vitest Tests 1783 passed; Surefire Failures: 0
  • downstream_checked: none (no public Java API / final / signature change; WebUI TS + product-docs + Playwright only)

Operator

Operator: Grok: night-issue-prs (model grok-4.5)

Fixes #2849

Co-Authored by Grok Build using grok-4.5 with agent main.

Compose rest/actions into product Explorer with toolbar/context-menu
surface filtering: drop desktop-only URLs and CONTEXTMENU roots on the
toolbar; keep context-menu surface for right-click. Load full cascading
action tree for folder context (no item=true filter). Vitest for
enablement helpers and shell mount; Playwright us1-core-explorer
assertion; product-docs Content Explorer page.

Fixes #2849
Parent: #2407 / #2400

> Co-Authored by Grok Build using grok-4.5 with agent main.
@natechadwick-intsof

Copy link
Copy Markdown
Collaborator Author

Human QA handoff: #2856 (@vijaya-boddipudi)

Co-Authored by Grok Build using grok-4.5 with agent main.

Comment thread modules/perc-qa-automation/frontend/tests/us1-core-explorer.spec.js
@kilo-code-bot

kilo-code-bot Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • modules/perc-qa-automation/frontend/tests/us1-core-explorer.spec.js - previous enablement-filtering assertion gap addressed; no new issues in changed lines
Previous Review Summary (commit 64dfc6b)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 64dfc6b)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
modules/perc-qa-automation/frontend/tests/us1-core-explorer.spec.js 99 Playwright test does not assert enablement filtering behavior in the live-CMS path; only toolbar mount and context-menu presence are verified. Consider adding a filtered-state assertion when the catalog supports it.
Files Reviewed (9 files)
  • WebUI/src/main/ts/contentExplorer/ContentExplorerShell.tsx - enablement filtering integration
  • WebUI/src/main/ts/contentExplorer/actionEnablement.ts - new enablement helpers
  • WebUI/src/test/ts/contentExplorer/ContentExplorerShell.test.tsx - shell integration test
  • WebUI/src/test/ts/contentExplorer/actionEnablement.test.ts - new unit tests
  • WebUI/src/test/ts/contentExplorer/index.ts - test index update
  • modules/perc-qa-automation/frontend/tests/us1-core-explorer.spec.js - Playwright coverage
  • product-docs/8.2/admin/content-explorer.md - new docs page
  • product-docs/8.2/admin/index.md - nav link
  • product-docs/8.2/admin/sites.md - related link

Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash · Input: 51K · Output: 5.4K · Cached: 262.5K

Review guidance: REVIEW.md from base branch main

Intercept /actions/find* to inject a desktop-only action and assert it is
absent from toolbar and context menu (filterToolbarActions /
filterContextMenuActions live path). Addresses kilo review on PR #2855.

> Co-Authored by Grok Code using grok with agent overnight-pr-followup.
@natechadwick
natechadwick merged commit 671af17 into main Aug 11, 2026
9 checks passed
@natechadwick
natechadwick deleted the feat/issue-2849-explorer-action-toolbar-context-menu branch August 11, 2026 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:grok-4.5 Grok 4.5 model operator:grok Changes authored by Grok operator:night-issue-prs night-issue-prs workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue 2407 slice 2: Server action toolbar + context menu in Explorer shell

2 participants