Repository navigation
feat(WebUI): Explorer action toolbar + context menu enablement (#2849) - #2855
Merged
natechadwick merged 2 commits intoAug 11, 2026
Merged
Conversation
Compose rest/actions into product Explorer with toolbar/context-menu surface filtering: drop desktop-only URLs and CONTEXTMENU roots on the toolbar; keep context-menu surface for right-click. Load full cascading action tree for folder context (no item=true filter). Vitest for enablement helpers and shell mount; Playwright us1-core-explorer assertion; product-docs Content Explorer page. Fixes #2849 Parent: #2407 / #2400 > Co-Authored by Grok Build using grok-4.5 with agent main.
This was referenced Aug 10, 2026
Collaborator
Author
|
Human QA handoff: #2856 (@vijaya-boddipudi)
|
4 tasks
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Previous Review Summary (commit 64dfc6b)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 64dfc6b)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (9 files)
Reviewed by step-3.7-flash · Input: 51K · Output: 5.4K · Cached: 262.5K Review guidance: REVIEW.md from base branch |
4 of 5 tasks
Intercept /actions/find* to inject a desktop-only action and assert it is absent from toolbar and context menu (filterToolbarActions / filterContextMenuActions live path). Addresses kilo review on PR #2855. > Co-Authored by Grok Code using grok with agent overnight-pr-followup.
natechadwick
approved these changes
Aug 11, 2026
natechadwick
deleted the
feat/issue-2849-explorer-action-toolbar-context-menu
branch
August 11, 2026 01:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #2849 (slice 2 of #2407 / grandparent #2400): product Explorer server action toolbar + item/folder context menu composition from existing
rest/actions, with client-side enablement helpers that hide desktop-only / non-web-executable actions and routeCONTEXTMENUroots to the popup only.Changes
actionEnablement.ts: pure helpers (filterToolbarActions/filterContextMenuActions, desktop URL detection, CLIENT sentinel handling, surface rules).ContentExplorerShell: apply enablement after catalog + workflow merge; load full cascading tree for folder context (dropitem=truewhich only kept flat MENUITEM roots).actionEnablement.test.ts(11) + shell test for toolbar filter + context-menu mount.us1-core-explorerasserts toolbar + right-click context menu when rows exist.Out of scope (unchanged)
Parent / slices
Test plan
cd WebUI && ../mvnw.cmd clean install— BUILD SUCCESSus1-core-exploreragainst QA H2 when available (assertions added)Product documentation
product-docs/(8.2/admin/content-explorer.md, admin index, sites related link)Build evidence (C3)
WebUIcd WebUI; ..\mvnw.cmd clean install→ BUILD SUCCESS; Vitest Tests 1783 passed; Surefire Failures: 0Operator
Operator: Grok: night-issue-prs (model grok-4.5)
Fixes #2849