Repository navigation
feat(WebUI): Explorer Search panel toggle + shell chrome Playwright (#2850) - #2857
Merged
Merged
Conversation
natechadwick-intsof
added
operator:grok
This was referenced Aug 10, 2026
Collaborator
Author
|
Human QA issue: #2858 (@vijaya-boddipudi)
|
4 tasks
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (15 files)
Previous Review Summaries (2 snapshots, latest commit a609db5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a609db5)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit 0c4d8a9)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (16 files)
Reviewed by step-3.7-flash · Input: 110.2K · Output: 18.4K · Cached: 861.6K Review guidance: REVIEW.md from base branch |
4 of 5 tasks
natechadwick-intsof
added a commit
that referenced
this pull request
Aug 11, 2026
Address kilo review on PR #2857: - Content → Search open/close + aria-expanded - Playwright Content Search aria-expanded transitions - Move displayFormat out of menu-bar helper (shell-chrome only) - Assert listSavedSearches / executeSavedSearch shell pass-through > Co-Authored by Grok Code using grok with agent overnight-pr-followup.
natechadwick
previously approved these changes
Aug 11, 2026
natechadwick
enabled auto-merge (squash)
August 11, 2026 02:01
…2850) Complete #2407 slice 3: Content/View Search share one product Search panel with menuitemcheckbox a11y, shell search injectors for Vitest, and a surface-filtered Playwright suite for menu bar, display format, action toolbar, and free-text Search chrome. Product docs cover Search + shell. Fixes #2850 Parent: #2407 / Grandparent: #2400 > Co-Authored by Grok Build using grok-4.5 with agent main.
Address kilo review on PR #2857: - Content → Search open/close + aria-expanded - Playwright Content Search aria-expanded transitions - Move displayFormat out of menu-bar helper (shell-chrome only) - Assert listSavedSearches / executeSavedSearch shell pass-through > Co-Authored by Grok Code using grok with agent overnight-pr-followup.
Collaborator
Author
|
Rebased onto
Code/tests from the branch rebased cleanly; docs-only conflict resolution.
|
natechadwick-intsof
force-pushed
the
feat/issue-2850-explorer-search-shell-chrome
branch
from
August 11, 2026 02:39
a609db5 to
a7727e6
Compare
natechadwick
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #2850 (slice 3 of #2407 / grandparent #2400): product Explorer Search panel toggle composition + surface-filtered Playwright shell chrome assertions.
Changes
menuitemcheckboxtoggle sharing the same panel as View → Search (aria-controls=explorer-search-panel, Content menu stays open for flip)search/listSavedSearches/executeSavedSearchpassed through toSearchPanelfolderPath+ query)tests/explorer-shell-chrome.spec.js(@explorer-shell-chrome/@search/@smoke) — menu bar, display format, action toolbar region, Search open/close + free-text chrome + axe gateexplorer-shell-chrome.js+ unit tests wired intonpm run test:unitproduct-docs/8.2/admin/content-explorer.md(Search + shell chrome) + admin index / sites linksOut of scope
Parent / slices
Test plan
cd WebUI && ../mvnw.cmd clean install— BUILD SUCCESS; Vitest 1776 passedcd modules/perc-qa-automation && ../../mvnw.cmd clean install— BUILD SUCCESSnpm run test:unitin perc-qa-automation/frontend — 218 passed (includes explorer-shell-chrome)npm run test:surface:list -- --path tests/explorer-shell-chrome.spec.js— 4 tests listedtest:surfaceagainst H2 QA — soft-skip documented: existing matrix CMS on:9993returned 503; did not start a second qa-up against unhealthy stack. Human QA / next healthyperc-devctl qa-upshould run surface path below.Product documentation
product-docs/(8.2/admin/content-explorer.md, admin index, sites related link)Build evidence (C3)
WebUI,modules/perc-qa-automationcd WebUI; ..\mvnw.cmd clean install→ BUILD SUCCESS; Vitest Tests 1776 passedcd modules/perc-qa-automation; ..\..\mvnw.cmd clean install→ BUILD SUCCESSnpm run test:unit→ 218 passedOperator
Operator: Grok: night-issue-prs (model grok-4.5)
Fixes #2850