Skip to content

rename Transform::compute_matrix to to_matrix #19646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rename Transform::compute_matrix to to_matrix #19646

wants to merge 1 commit into from
+5 −5

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jun 14, 2025

Objective

Solution

  • Rename

Testing

  • None

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jun 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

alice-i-cecile
alice-i-cecile requested changes Jun 14, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a migration guide :)

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged D-Trivial Nice and easy! A great choice to get started with Bevy A-Math Fundamental domain-agnostic mathematical operations and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 14, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jun 14, 2025
janhohenheim
janhohenheim approved these changes Jun 14, 2025
View reviewed changes
crates/bevy_transform/src/components/transform.rs
/// rotation, and scale.
#[inline]
pub fn compute_matrix(&self) -> Mat4 {
pub fn to_matrix(&self) -> Mat4 {
Copy link
Member

@janhohenheim janhohenheim Jun 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do we even need this method if we implemented From<Transform> for Mat4? oh I see, people on Discord seem to agree that From should not be implemented here
  • Also, do we want to keep a deprecated alias for a nicer migration?
  • Anyways, better than the current state of things :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, this is pretty easy to figure out and niche. The deprecated alias is solidly nice-to-have.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 14, 2025
@alice-i-cecile
Copy link
Member

Ping about the migration guide :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

@mweatherley mweatherley mweatherley approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @alice-i-cecile @mweatherley @janhohenheim