Skip to content

rename GlobalTransform::compute_matrix to to_matrix #19643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

rename GlobalTransform::compute_matrix to to_matrix #19643

merged 5 commits into from
Jun 17, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jun 14, 2025

Objective

  • compute_matrix doesn't compute anything, it just puts an Affine3A into a Mat4. the name is inaccurate

Solution

  • rename it to conform with to_isometry (which, ironically, does compute a decomposition which is rather expensive)

Testing

  • Its a rename. If it compiles, its good to go

@IQuick143 IQuick143 added A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jun 14, 2025
@IQuick143 IQuick143 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 14, 2025
@atlv24 atlv24 mentioned this pull request Jun 14, 2025
Open
@alice-i-cecile
Copy link
Member

@atlv24 can you resolve merge conflicts please?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 17, 2025
Merged via the queue into bevyengine:main with commit 2915a3b Jun 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

@mweatherley mweatherley mweatherley approved these changes

@IQuick143 IQuick143 IQuick143 approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @alice-i-cecile @mweatherley @IQuick143