Skip to content

Conversation

@algojack
Copy link
Contributor

@algojack algojack commented Aug 24, 2021

GitHub Logo

Highlights

This is a maintenance release focused around many test improvements and other optimizations.

Changes

  1. REST API
  2. TEAL
  3. Ledger
  4. Node
  5. Metrics
  6. Goal
  7. Other

Protocol Upgrade

This release does not contain a protocol upgrade.

Additional Resources

jannotti and others added 2 commits August 24, 2021 14:17
…lgorand#2784)

This also unifies a lot of field handling so that the code is less
susceptible to copy-paste errors, but it has a ways to go. Hard to
both unify the handling of the different fields and use separate
types for each field index. Lots and lots of interfaces could do. Or
generics in 6 months? For the moment, each field type is a pile of
arrays and maps working together.

It's unclear what we gain from those separate index types, since
we always cast into the type just before using them, as we are
getting the indexes from reading a byte in bytecode.

New tests will catch this mistake if we make it again.
@algojack algojack self-assigned this Aug 24, 2021
@algojack algojack marked this pull request as ready for review August 24, 2021 18:49
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #2800 (f2be951) into rel/beta (1f05448) will decrease coverage by 0.02%.
The diff coverage is 76.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rel/beta    #2800      +/-   ##
============================================
- Coverage     47.14%   47.11%   -0.03%     
============================================
  Files           349      349              
  Lines         56321    56351      +30     
============================================
- Hits          26550    26548       -2     
- Misses        26800    26830      +30     
- Partials       2971     2973       +2     
Impacted Files Coverage Δ
data/transactions/logic/fields.go 83.58% <65.38%> (-12.58%) ⬇️
data/transactions/logic/eval.go 90.32% <75.67%> (-0.33%) ⬇️
data/transactions/logic/assembler.go 82.34% <83.87%> (-0.14%) ⬇️
data/transactions/logic/debugger.go 51.42% <100.00%> (ø)
network/wsPeer.go 74.65% <0.00%> (-3.35%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
data/transactions/verify/txn.go 45.08% <0.00%> (-0.90%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
network/wsNetwork.go 60.73% <0.00%> (-0.19%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f05448...f2be951. Read the comment docs.

Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@algojohnlee algojohnlee merged commit d1aca92 into algorand:rel/beta Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants