Skip to content

Conversation

@algojack
Copy link
Contributor

Summary

Test Plan

@algojack algojack self-assigned this Jul 16, 2021
@algojack
Copy link
Contributor Author

Did I correctly understand the feedback from previous PRs for github template changes? @onetechnical @winder @yaovi-a ?

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #2568 (608d744) into master (c983ad6) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
+ Coverage   46.87%   46.93%   +0.05%     
==========================================
  Files         346      348       +2     
  Lines       55668    55686      +18     
==========================================
+ Hits        26094    26134      +40     
+ Misses      26619    26605      -14     
+ Partials     2955     2947       -8     
Impacted Files Coverage Δ
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.86% <0.00%> (-1.01%) ⬇️
ledger/acctupdates.go 61.91% <0.00%> (-0.42%) ⬇️
libgoal/lockedFileUnix.go 0.00% <0.00%> (ø)
util/db/fullfsync_darwin.go 100.00% <0.00%> (ø)
network/wsNetwork.go 60.92% <0.00%> (+0.18%) ⬆️
util/db/dbutil.go 39.54% <0.00%> (+0.56%) ⬆️
catchup/service.go 69.79% <0.00%> (+0.78%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️
ledger/catchpointwriter.go 69.48% <0.00%> (+1.29%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c983ad6...608d744. Read the comment docs.

@algojack
Copy link
Contributor Author

I don't have the permission to merge (for a good reason). @algojohnlee @onetechnical can you please merge?

@algojohnlee algojohnlee merged commit a398362 into master Jul 21, 2021
@algojack algojack deleted the jack/update-feature-request-github-template branch July 21, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants