Add batch verification #2578
Merged
Add batch verification #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding the batch verification object + tests
use the batch verifier for multisig
using the batch verification in logicsignatures .
Codecov Report
@@ Coverage Diff @@
## master #2578 +/- ##
=======================================
Coverage 47.07% 47.07%
=======================================
Files 349 350 +1
Lines 55858 55925 +67
=======================================
+ Hits 26294 26327 +33
- Misses 26617 26646 +29
- Partials 2947 2952 +5
Continue to review full report at Codecov.
|
added 3 commits
July 18, 2021 10:15
…and into add-batch-verification
algonathan
reviewed
Jul 18, 2021
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
looks good. two minor comments, but neither of them would be a blocker.
…and into add-batch-verification
fixing comments
tsachiherman
reviewed
Aug 4, 2021
tsachiherman
reviewed
Aug 4, 2021
tsachiherman
suggested changes
Aug 4, 2021
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
Two small comments, but looks good otherwise!
tsachiherman
approved these changes
Aug 7, 2021
This was referenced Aug 19, 2021
tmc
pushed a commit
to tmc/go-algorand
that referenced
this pull request
Mar 7, 2025
Add the framework for supporting batch verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan