Extend global and txn field tests for all TEAL versions and protocols #2669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
force-pushed
the
pavel/teal-tests
branch
from
e62953e to
94920c4
Compare
tsachiherman
reviewed
Aug 3, 2021
tsachiherman
previously approved these changes
Aug 3, 2021
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
Looks great, 1 small possible improvement.
jannotti
reviewed
Aug 3, 2021
algorandskiy
force-pushed
the
pavel/teal-tests
branch
from
94920c4 to
4ad8cfc
Compare
jannotti
previously approved these changes
Aug 3, 2021
data/transactions/logic/eval_test.go
Outdated
* Move tests from backwardCompat_test.go to fields_test.go * Check every field on a version before it was introduced * Enable txna fields checks * Fix TestGlobal to prevent invalid version specs in tests map
algorandskiy
force-pushed
the
pavel/teal-tests
branch
from
4ad8cfc to
0510b0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2669 +/- ##
==========================================
- Coverage 47.05% 47.04% -0.01%
==========================================
Files 349 349
Lines 55833 55833
==========================================
- Hits 26271 26266 -5
- Misses 26613 26620 +7
+ Partials 2949 2947 -2
Continue to review full report at Codecov.
|
jannotti
approved these changes
Aug 3, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
This is tests improvement PR