-
Notifications
You must be signed in to change notification settings - Fork 523
Add additional functions to improve type tracking of AVM stack manipulation opcodes #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge for extra opTypeFuncs
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
==========================================
+ Coverage 47.08% 47.12% +0.03%
==========================================
Files 349 349
Lines 55887 55914 +27
==========================================
+ Hits 26316 26350 +34
+ Misses 26619 26616 -3
+ Partials 2952 2948 -4
Continue to review full report at Codecov.
|
|
I think these are good, @AyAggarwal and/or @algochoi could you give any quick feedback. Ilan is my intern working on improving Teal type checking, this is just getting this started with a small PR to do the other typecheck functions. |
algochoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
looks good to me too! Seems like all opcodes that need type checking will get a similar treatment. perhaps this workflow should be added to the "writing opcodes notes" |
This is a quick PR that follows up on the infrastructure JJ built in Infrastructure to check AVM stack manipulation opcodes better. It adds type functions for ==, !=, select, dup, dup2, and setbit as well as updating the tests to reflect these changes.