Skip to content

Conversation

@iten-alg
Copy link
Contributor

@iten-alg iten-alg commented Aug 6, 2021

This is a quick PR that follows up on the infrastructure JJ built in Infrastructure to check AVM stack manipulation opcodes better. It adds type functions for ==, !=, select, dup, dup2, and setbit as well as updating the tests to reflect these changes.

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #2710 (15a0ee4) into master (26c4692) will increase coverage by 0.03%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2710      +/-   ##
==========================================
+ Coverage   47.08%   47.12%   +0.03%     
==========================================
  Files         349      349              
  Lines       55887    55914      +27     
==========================================
+ Hits        26316    26350      +34     
+ Misses      26619    26616       -3     
+ Partials     2952     2948       -4     
Impacted Files Coverage Δ
data/transactions/logic/opcodes.go 96.00% <ø> (ø)
data/transactions/logic/assembler.go 82.47% <92.59%> (+0.20%) ⬆️
network/requestTracker.go 70.25% <0.00%> (-0.87%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
network/wsPeer.go 74.65% <0.00%> (-0.28%) ⬇️
ledger/acctupdates.go 62.13% <0.00%> (-0.17%) ⬇️
network/wsNetwork.go 61.21% <0.00%> (+0.28%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26c4692...15a0ee4. Read the comment docs.

@jannotti
Copy link
Contributor

I think these are good, @AyAggarwal and/or @algochoi could you give any quick feedback. Ilan is my intern working on improving Teal type checking, this is just getting this started with a small PR to do the other typecheck functions.

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AyAggarwal
Copy link
Contributor

AyAggarwal commented Aug 10, 2021

looks good to me too! Seems like all opcodes that need type checking will get a similar treatment. perhaps this workflow should be added to the "writing opcodes notes"

@jannotti jannotti merged commit dd7f7b6 into algorand:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants