Type funcs 2 #4
Type funcs 2 #4
Conversation
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Looks very good. Just a few comments. Then I'd say make it under a nice branch name and PR it to go-algorand.
data/transactions/logic/assembler.go
Outdated
| topTwo[1] = ops.typeStack[top] | ||
| topTwo[0] = ops.typeStack[top] |
There was a problem hiding this comment.
I think you can do this nicely as return {ops.typeStack[top], ops.typeStack[top]}
A comment like "stackargs should have the same type" would be good.
data/transactions/logic/assembler.go
Outdated
| topTwo[1] = ops.typeStack[top] | ||
| topTwo[0] = ops.typeStack[top] | ||
| } | ||
| return topTwo, oneInt |
There was a problem hiding this comment.
Then you would not even define topTwo and return with a composite literal here too.
| return topTwo, oneInt | ||
| } | ||
|
|
||
| func typeDup(ops *OpStream, args []string) (StackTypes, StackTypes) { |
There was a problem hiding this comment.
Similar literal handling.
|
|
||
| func TestDupTypeCheck(t *testing.T) { | ||
| t.Parallel() | ||
| testProg(t, "int 1; byte 0x1234; dup; +", AssemblerMaxVersion, expect{4, "+ arg 1..."}) |
There was a problem hiding this comment.
I think this would have failed before (maybe the error changes slightly with the better checking, but stack for + would be {int, bytes, any} which is bad.
Better to try dup and then put a 1 on the stack, and see if + works, so top of stack was {any, int} but is now {byte, int}
This PR adds the remaining typeFuncs (for ==, !=, dup, dup2, select, and setbit)