Skip to content

Conversation

@winder
Copy link
Contributor

@winder winder commented Jul 30, 2021

Summary

The REST API generate command is failing to install oapi-codegen because it needs an older version of kin-openapi than we define in go.sum. I'm attempting to install it with the buildtools script.

Also added REST server generation to the codegen test.

Test Plan

CI

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2021

Codecov Report

Merging #2668 (f17aa05) into master (d1425f0) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f17aa05 differs from pull request most recent head e9eed05. Consider uploading reports for the commit e9eed05 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2668      +/-   ##
==========================================
+ Coverage   47.00%   47.04%   +0.03%     
==========================================
  Files         349      349              
  Lines       55814    55814              
==========================================
+ Hits        26238    26256      +18     
+ Misses      26623    26608      -15     
+ Partials     2953     2950       -3     
Impacted Files Coverage Δ
ledger/acctupdates.go 61.88% <0.00%> (-0.42%) ⬇️
catchup/service.go 69.35% <0.00%> (ø)
network/wsNetwork.go 60.92% <0.00%> (ø)
data/transactions/verify/txn.go 48.45% <0.00%> (ø)
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️
network/wsPeer.go 75.48% <0.00%> (+3.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1425f0...e9eed05. Read the comment docs.

Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tsachiherman tsachiherman merged commit eb01929 into algorand:master Aug 4, 2021
@winder winder deleted the will/fix-oapi-codegen-install branch August 4, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants