Wrap up TBD items on circleCI work #2444
Conversation
Co-authored-by: Will Winder <wwinder.unh@gmail.com>
This is a test to make sure that coverage reports show up from circle
bricerisingalgorand
force-pushed
the
brice/wrapUpCircleCI
branch
from
ac022ae to
afc761b
Compare
test/scripts/e2e_go_tests.sh
Outdated
| PACKAGE_NAMES=$(echo $PACKAGES | tr -d '\n') | ||
| echo "Testing the following packages:" | ||
| echo $PACKAGE_NAMES | ||
| gotestsum --format pkgname --junitfile $TEST_RESULTS/results.xml --jsonfile $TEST_RESULTS/testresults.json -- ${RACE_OPTION} ${PARALLEL_FLAG} -timeout 1h -v ${SHORTTEST} ${PACKAGE_NAMES} |
There was a problem hiding this comment.
Unfortunately, I don't think this change is quite right. GOTESTCOMMAND isn't being set and it defaults to go test, so after this change we'll revert back to go test. If we switch to calling make integration instead of no longer be setting ./test/scripts/run_integration_tests.sh, then GOTESTCOMMAND will be set but wont include --junitfile $TEST_RESULTS/results.xml --jsonfile $TEST_RESULTS/testresults.json.
There was a problem hiding this comment.
This is some dead code and so this code path was not being exercised because USE_CIRCLECI_SPLIT is not set anywhere. This commit should have no effect on the tests we're running in CircleCI.
I'm not sure how running make targets will work after attaching a workspace saved by a different job.
Barbara/circle filter
Barbara/fixgofmt
remove CIRCLECI_SPLIT
|
Could you update your review if you think it looks ok @tsachiherman? |
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Approved pending follow-up tickets (my priorities in parens):
- verify codecov report still working and correct (high)
- router_test.go test suite isn't partitioned (high)
- unify gotestsum configuration (medium)
- consistent SKIP_E2E_SUBS / E2E_SUBS_ONLY convention -
SKIP_orENABLE_, not both. (medium) NO_GIMME->SKIP_GO_INSTALLATION(medium)- verify that go e2e tests are included in reporting, I think that gotestsum may not be properly initialized (medium)
- unify script changes (medium-low)
- fix import orders to match our convention (low)
12 participants
Summary
I'm making this PR at the start of work so that I can continuously see that it's running the circleci jobs correctly. Below are the items I am working on:
Will do later