bug: disable networking on devmode #2601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2601 +/- ##
==========================================
+ Coverage 46.92% 46.99% +0.06%
==========================================
Files 346 348 +2
Lines 55697 55715 +18
==========================================
+ Hits 26137 26183 +46
+ Misses 26611 26591 -20
+ Partials 2949 2941 -8
Continue to review full report at Codecov.
|
winder
reviewed
Jul 21, 2021
Comment on lines
170
to
+172
| cfg.DisableNetworking = true | ||
| } | ||
| node.config = cfg |
Contributor
There was a problem hiding this comment.
Suggested change
| cfg.DisableNetworking = true | |
| } | |
| node.config = cfg | |
| node.config.DisableNetworking = true | |
| } |
Contributor
Author
There was a problem hiding this comment.
I was hoping to avoid setting this field twice - instead, I think that we should try and have a single copy of the config.Local. Until we do this, I think that ensuring that we "just" copy it here would make the next change slightly easier.
Contributor
There was a problem hiding this comment.
Oops, I didn't realize cfg was used below as well.
jdtzmn
approved these changes
Jul 21, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current code would not pass the
DisableNetworkingflag to the network package. This could be worked around by adding theDisableNetworkingto theconfig.jsonfile, or with this fix.Test Plan
Tested manually.