Record modified local creatable states in state delta. #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorandskiy
reviewed
Aug 2, 2021
Comment on lines
+141
to
+144
| err = balances.DeallocateAsset(creator, cc.ConfigAsset, false) | ||
| if err != nil { | ||
| return err | ||
| } |
Contributor
There was a problem hiding this comment.
double call does not look good, how about adding bit flags specifying global or local, or both.
Contributor
Author
There was a problem hiding this comment.
What's wrong with double call? Asset params and asset holdings are modified separately in account data.
Contributor
Author
There was a problem hiding this comment.
The Balance interface is simpler as is.
Contributor
There was a problem hiding this comment.
Calling twice is a clear indication that the interface is wrong.. I'd agree with Pavel that we should update the function call.
tsachiherman
approved these changes
Aug 3, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Indexer needs the list of deleted local creatable states. This PR adds this information in ledger's state delta.
Test Plan
Added unit tests.